From: Jonathan Nieder <jrnieder@gmail.com>
To: Chris Johnsen <chris_johnsen@pobox.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Documentation/Makefile: fix interrupted builds of user-manual.xml
Date: Thu, 22 Apr 2010 05:24:09 -0500 [thread overview]
Message-ID: <20100422102254.GA701@progeny.tock> (raw)
In-Reply-To: <FA4A6177-AB3E-4C5C-8042-1BFBAE09528B@pobox.com>
Chris Johnsen wrote:
> On 2010 Apr 21, at 20:18, Jonathan Nieder wrote:
>> user-manual.html: user-manual.xml
>> - $(QUIET_XSLTPROC)xsltproc $(XSLTOPTS) -o $@ $(XSLT) $<
>> + $(QUIET_XSLTPROC)$(RM) $@+ $@ && \
>> + xsltproc $(XSLTOPTS) -o $@+ $(XSLT) $< && \
>> + mv $@+ $@
>>
[...]
> I suppose it is obvious enough what is going on in this in this
> second hunk, but there is no mention of this change in the commit
> message. Is this hunk due to a similar problem with xsltproc? Or
> maybe this is just "defensive coding"?
xsltproc indeed has the same problem, as I learned while testing
the first hunk. Thanks for asking.
Sorry for the incomplete explanation before.
Jonathan
prev parent reply other threads:[~2010-04-22 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 1:18 [PATCH] Documentation/Makefile: fix interrupted builds of user-manual.xml Jonathan Nieder
2010-04-22 6:13 ` Chris Johnsen
2010-04-22 10:24 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100422102254.GA701@progeny.tock \
--to=jrnieder@gmail.com \
--cc=chris_johnsen@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).