git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Ricky Clarkson <ricky.clarkson@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Case sensitivity on Windows for absolute paths.
Date: Fri, 23 Apr 2010 21:46:56 +0200	[thread overview]
Message-ID: <201004232146.56424.j6t@kdbg.org> (raw)
In-Reply-To: <o2v7eeb06461004230712i2c8c1e61l4c50a73a4f6c83d@mail.gmail.com>

On Freitag, 23. April 2010, Ricky Clarkson wrote:
> I noticed that if I have a git repository at C:\foo, and there is a
> file in there named bar, git add bar works fine, git add C:\foo/bar
> works fine but git add c:\foo/bar does not.  git reports that the file
> 'is outside repository'.  Looking at setup.c it seems that string
> comparisons are being used to determine whether a file is within the
> repository.

Yes, we should be a bit more liberal when drive letters are compared; they 
should be treated in a case-insensitive manner, but currently we are strict.

> For my purposes I can probably make a Windows build that does it while
> ignoring the case, but is there a more proper way that git should do
> it?  I'm not familiar enough with the POSIX file routines to know.

My guess is that it is sufficient that

1. the internal version of GIT_DIR is recorded with an uppercase drive letter;

2. normalize_path_copy() upper-cases the drive letter.

Then the comparison in prefix_path() should do the right thing.

-- Hannes

  reply	other threads:[~2010-04-23 19:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-23 14:12 Case sensitivity on Windows for absolute paths Ricky Clarkson
2010-04-23 19:46 ` Johannes Sixt [this message]
2010-04-25  7:33   ` Ricky Clarkson
2010-04-25 18:08     ` Johannes Sixt
2010-04-25 18:47       ` Ricky Clarkson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004232146.56424.j6t@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=git@vger.kernel.org \
    --cc=ricky.clarkson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).