From: Jonathan Nieder <jrnieder@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Mark Lodato <lodatom@gmail.com>,
git@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>
Subject: [PATCH 0/2] fast-import: tighten up parsing ident line
Date: Sat, 24 Apr 2010 15:38:27 -0500 [thread overview]
Message-ID: <20100424203827.GA24948@progeny.tock> (raw)
In-Reply-To: <20100424190419.GA7502@spearce.org>
Shawn O. Pearce wrote:
> Jonathan Nieder <jrnieder@gmail.com> wrote:
>> git fast-import is capable of producing commits with some of these
>> problems: for example, it is fine with
>>
>> committer C O Mitter <foo@b>ar.net> 005 - +5
>
> Yuck. We probably should tighten up the parser in fast-import a
> bit more.
How about this?
Jonathan Nieder (2):
fast-import: be strict about formatting of dates
fast-import: validate entire ident string
Documentation/git-fast-import.txt | 9 ++--
fast-import.c | 63 ++++++++++++++--------
t/t9300-fast-import.sh | 105 +++++++++++++++++++++++++++++++++++++
3 files changed, 150 insertions(+), 27 deletions(-)
next prev parent reply other threads:[~2010-04-24 20:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-24 0:45 [PATCH] fast-import docs: LT is valid in email, GT is not Mark Lodato
2010-04-24 16:06 ` [PATCH] fsck: check ident lines in commit objects Jonathan Nieder
2010-04-24 16:59 ` Jonathan Nieder
2010-04-24 19:04 ` Shawn O. Pearce
2010-04-24 20:38 ` Jonathan Nieder [this message]
2010-04-24 20:50 ` [PATCH 1/2] fast-import: be strict about formatting of raw dates Jonathan Nieder
2010-04-24 21:10 ` [PATCH 2/2] fast-import: validate entire ident string Jonathan Nieder
2010-04-26 16:02 ` Shawn O. Pearce
2010-04-26 16:24 ` Jonathan Nieder
2010-04-26 16:30 ` Jonathan Nieder
2010-05-04 17:11 ` Junio C Hamano
2010-04-24 16:12 ` [PATCH] fast-import docs: LT is valid in email, GT is not Jonathan Nieder
2010-04-24 16:59 ` Mark Lodato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100424203827.GA24948@progeny.tock \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=lodatom@gmail.com \
--cc=nico@fluxnic.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).