From: Jakub Narebski <jnareb@gmail.com>
To: Petr Baudis <pasky@suse.cz>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/5] gitweb: Miscellaneous improvements, in preparation for caching support
Date: Sun, 25 Apr 2010 13:45:57 +0200 [thread overview]
Message-ID: <201004251346.01183.jnareb@gmail.com> (raw)
In-Reply-To: <20100425092035.GO3563@machine.or.cz>
Petr Baudis wrote:
> On Sat, Apr 24, 2010 at 03:46:25PM +0200, Jakub Narebski wrote:
> > Jakub Narebski (5):
> > gitweb: Move generating page title to separate subroutine
> > gitweb: Add custom error handler using die_error
> > gitweb: Use nonlocal jump instead of 'exit' in die_error
> > gitweb: href(..., -path_info => 0|1)
> > Export more test-related variables when running external tests
> >
> > gitweb/gitweb.perl | 69 ++++++++++++++++++++++++++++++++++++++--------------
> > t/test-lib.sh | 3 ++
> > 2 files changed, 53 insertions(+), 19 deletions(-)
> > mode change 100644 => 100755 t/test-lib.sh
Ooops, the mode change was accidental.
>
> Except the last one, I don't think the patches bring something useful
> in on their own so ordinarily they would probably have to be a part of
> some series that makes use of them, but there's no harm done either.
Actually "gitweb: Use nonlocal jump instead of 'exit' in die_error"
could in theory improve performance of gitweb on mod_perl, but I have
not benchmarked it...
--
Jakub Narebski
Poland
prev parent reply other threads:[~2010-04-25 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-24 13:46 [PATCH 0/5] gitweb: Miscellaneous improvements, in preparation for caching support Jakub Narebski
2010-04-24 13:50 ` [PATCH 1/5] Export more test-related variables when running external tests Jakub Narebski
2010-04-25 11:47 ` Jakub Narebski
2010-04-24 13:53 ` [PATCH 2/5] gitweb: href(..., -path_info => 0|1) Jakub Narebski
2010-04-24 13:56 ` [PATCH 3/5] gitweb: Use nonlocal jump instead of 'exit' in die_error Jakub Narebski
2010-05-04 11:39 ` Jakub Narebski
2010-04-24 14:00 ` [PATCH 4/5] gitweb: Add custom error handler using die_error Jakub Narebski
2010-04-24 14:01 ` [PATCH 5/5] gitweb: Move generating page title to separate subroutine Jakub Narebski
2010-04-25 9:20 ` [PATCH 0/5] gitweb: Miscellaneous improvements, in preparation for caching support Petr Baudis
2010-04-25 11:45 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004251346.01183.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).