git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Vajna <vmiklos@frugalware.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Thomas Rast <trast@student.ethz.ch>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/2] request-pull: protect against OPTIONS_KEEPDASHDASH from environment
Date: Mon, 26 Apr 2010 02:12:56 +0200	[thread overview]
Message-ID: <20100426001256.GJ19595@genesis.frugalware.org> (raw)
In-Reply-To: <20100424120437.GA12237@progeny.tock>

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

On Sat, Apr 24, 2010 at 07:10:10AM -0500, Jonathan Nieder <jrnieder@gmail.com> wrote:
> At last, the mysterious t7400 test failure has been solved, thanks to
> Gerrit Pape.  It was caused by an assumption in git that a certain
> variable not in its namespace would not be set.
> 
> Here???s a problem of the same kind, though harder to trip.  I can???t
> imagine why anyone would be exporting the OPTIONS_KEEPDASHDASH
> variable, but it is not in git???s namespace so it seems better not
> to make any assumptions.

Ack - I really just did cosmetics on request-pull's output, nothing
more. :)

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

      parent reply	other threads:[~2010-04-26  0:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-24 12:10 [PATCH 0/2] request-pull: protect against OPTIONS_KEEPDASHDASH from environment Jonathan Nieder
2010-04-24 12:11 ` [PATCH 1/2] tests for request-pull Jonathan Nieder
2010-04-24 12:29   ` [PATCH] adapt request-pull tests for new pull request format Jonathan Nieder
2010-04-24 12:15 ` [PATCH 2/2] request-pull: protect against OPTIONS_KEEPDASHDASH from environment Jonathan Nieder
2010-04-25 12:34   ` Thomas Rast
2010-04-26  0:12 ` Miklos Vajna [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100426001256.GJ19595@genesis.frugalware.org \
    --to=vmiklos@frugalware.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).