From: Jakub Narebski <jnareb@gmail.com>
To: Petr Baudis <pasky@suse.cz>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCHv2 0/2] gitweb: Syntax highlighting support
Date: Tue, 27 Apr 2010 22:49:06 +0200 [thread overview]
Message-ID: <201004272249.06632.jnareb@gmail.com> (raw)
In-Reply-To: <20100427203225.GF10939@machine.or.cz>
On Tue, 27 Apr 2010, Petr Baudis napisał:
> On Tue, Apr 27, 2010 at 09:34:43PM +0200, Jakub Narebski wrote:
> > This series of patches is based originally on on Daniel Svensson's and
> > Sham Chukoury's work in gitweb-xmms2.git
>
> I have no major concerns, but I think it would be much simpler to just
> have a single squashed-together patch.
Note that first patch in series have different authorship. But perhaps
that doesn't matter much...
> Acked-by: Petr Baudis <pasky@suse.cz>
Thanks.
--
Jakub Narebski
Poland
prev parent reply other threads:[~2010-04-27 20:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 19:34 [PATCHv2 0/2] gitweb: Syntax highlighting support Jakub Narebski
2010-04-27 19:34 ` [PATCHv1 1/2] " Jakub Narebski
2010-04-27 19:34 ` [PATCHv2 2/2] gitweb: Refactor syntax " Jakub Narebski
2010-04-27 20:32 ` [PATCHv2 0/2] gitweb: Syntax " Petr Baudis
2010-04-27 20:49 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004272249.06632.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).