From: Jonathan Nieder <jrnieder@gmail.com>
To: Bill Pemberton <wfp5p@virginia.edu>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] blame: add a range option to -L
Date: Sun, 2 May 2010 04:14:34 -0500 [thread overview]
Message-ID: <20100502091433.GA1854@progeny.tock> (raw)
In-Reply-To: <1272662989-563-1-git-send-email-wfp5p@virginia.edu>
Bill Pemberton wrote:
> In addition to + and - you can now use r to specify how many lines
> around <start> that you want to see. For example: -L 20,r5 would show
> lines 15 through 25
From too much exposure to subversion, the r suggests “revision”.
But ± is too hard to type, so I guess r will have to do.
> +++ b/Documentation/blame-options.txt
> @@ -32,6 +32,12 @@ This is only valid for <end> and will specify a number
> of lines before or after the line given by <start>.
> +
>
> +- rrange
Maybe -rradius? “range” sounds like an interval with specified endpoints.
> + /* if top is negative then top is actually a range
> + that was specified with the r option */
> + if (*top < 1) {
> + long x = *top;
> + *top = *bottom - x;
> + *bottom += x;
> + if (*bottom < 1)
> + *bottom = 1;
> + }
How does this treat -L 5,-10?
Jonathan
next prev parent reply other threads:[~2010-05-02 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 21:29 [PATCH] blame: add a range option to -L Bill Pemberton
2010-05-02 9:14 ` Jonathan Nieder [this message]
2010-05-02 12:44 ` Michael Witten
2010-05-02 15:23 ` Junio C Hamano
2010-05-03 13:22 ` Bill Pemberton
2010-05-03 12:46 ` Bill Pemberton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100502091433.GA1854@progeny.tock \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).