From: Jonathan Nieder <jrnieder@gmail.com>
To: Eli Barzilay <eli@barzilay.org>
Cc: git@vger.kernel.org
Subject: Re: Distinguishing trivial and non-trivial merge commits
Date: Sun, 2 May 2010 13:18:54 -0500 [thread overview]
Message-ID: <20100502181854.GC16051@progeny.tock> (raw)
In-Reply-To: <19419.1721.763210.679444@winooski.ccs.neu.edu>
Eli Barzilay wrote:
> Using `--no-merges' helps in
> avoiding the confusing parts, but that's dangerous in omitting
> non-trivial merges too -- and those are probably even more worth
> noting than other changes (just because they'll highlights changes
> that are "hotter" in the sense of more people working on that code).
>
> The only way I've seen to distinguish the two is to use `git show' and
> see if there is no diff output (eg, "git show --pretty=format: $rev").
> But that doesn't help in getting the list of modified files.
Maybe --name-only or --name-status can help.
Note that most conflicts will not show up here: if the merge result
matches either parent, then git diff --cc and friends will not
consider it interesting at all. A command to list conflicts and their
resolutions would be expensive but valuable, I think. A naïve
implementation would involve redoing the merge.
[...]
> Is there *any* way to get `git diff --stat' to do the same thing that
> `git show' does? (Or a way to get `git show --stat' not show all
> files again...)
A “merge diffstat” sounds like an interesting idea, but the detailed
semantics are not obvious to me (maybe separate counts for nontrivial
added and removed lines from each parent?).
Thanks for the food for thought,
Jonathan
next prev parent reply other threads:[~2010-05-02 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 16:35 Distinguishing trivial and non-trivial merge commits Eli Barzilay
2010-05-02 18:18 ` Jonathan Nieder [this message]
2010-05-02 19:32 ` Eli Barzilay
2010-05-02 20:12 ` Jakub Narebski
2010-05-02 21:03 ` Eli Barzilay
2010-05-02 23:07 ` Junio C Hamano
2010-05-02 23:23 ` Eli Barzilay
2010-05-02 20:29 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100502181854.GC16051@progeny.tock \
--to=jrnieder@gmail.com \
--cc=eli@barzilay.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).