From: Jeff King <peff@peff.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH RFC] for-each-ref: Field with abbreviated objectname
Date: Tue, 4 May 2010 07:01:34 -0400 [thread overview]
Message-ID: <20100504110134.GA7947@coredump.intra.peff.net> (raw)
In-Reply-To: <61d114759b023b3937f8417ce44c3361f345c6f1.1272918259.git.git@drmicha.warpmail.net>
On Mon, May 03, 2010 at 10:25:19PM +0200, Michael J Gruber wrote:
> Introduce a :short modifier to objectname which outputs the abbreviated
> object name.
I don't see any reason not to do this if you have a use for it.
> TODO: test, doc
Yep.
> + else if (!strcmp(name, "objectname:short")) {
> + v->s = find_unique_abbrev(obj->sha1, DEFAULT_ABBREV);
> + }
In theory there could be multiple such ":$foo" tags, and we would have
to fix this parser. But given that there aren't other modifiers now, I
think we can just push that problem off until it happens (if ever).
-Peff
next prev parent reply other threads:[~2010-05-04 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 20:25 [PATCH RFC] for-each-ref: Field with abbreviated objectname Michael J Gruber
2010-05-04 11:01 ` Jeff King [this message]
2010-05-13 12:31 ` [PATCH] " Michael J Gruber
2010-05-14 5:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504110134.GA7947@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).