From: Jonathan Nieder <jrnieder@gmail.com>
To: Eli Barzilay <eli@barzilay.org>
Cc: Jared Hance <jaredhance@gmail.com>, git@vger.kernel.org
Subject: Re-submitting patches
Date: Wed, 5 May 2010 16:24:37 -0500 [thread overview]
Message-ID: <20100505212437.GA26487@progeny.tock> (raw)
In-Reply-To: <19425.56411.745112.753594@winooski.ccs.neu.edu>
Hi Eli,
Eli Barzilay wrote:
> On May 5, Eli Barzilay wrote:
>> (*sigh*) That's correct, I fixed this, but improperly remade the
>> patch.
>
> Is there some convention for sending a fixed patch?
With a small patch like this one, you can just send the fixed patch
as a reply to the thread. Putting “[PATCH v2]” in the subject would
make it clear that this is the newer and better version.
With larger patches, doing that too often can overload people.
My preferred solution: describe the changes as soon as you want, but
then take some time to polish them before resubmitting. This gives
people time to breathe. ;-)
The “ideal patch flow” section in Documentation/SubmittingPatches
says:
-------
(3) Polish, refine, and re-send to the list and the people who
spend their time to improve your patch. Go back to step (2).
-------
Maybe this could be clearer. In particular, sometimes it is not
obvious to people that even the patch submitter can pretend to be a
reviewer and discuss small incremental changes.
Thanks for bringing it up,
Jonathan
next prev parent reply other threads:[~2010-05-05 21:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 0:25 [PATCH] Set GIT_PATHNAME_PREFIX with aliases Jared Hance
2010-05-05 0:51 ` Jeff King
2010-05-05 6:53 ` Johannes Sixt
2010-05-05 7:01 ` Jeff King
2010-05-05 7:52 ` Eli Barzilay
2010-05-05 16:07 ` Junio C Hamano
2010-05-05 20:28 ` [PATCH] An alias that starts with "!!" runs in the current directory Eli Barzilay
2010-05-05 20:52 ` [PATCH] An alias that starts with "!!" " Jared Hance
2010-05-05 20:58 ` Eli Barzilay
2010-05-05 21:00 ` Eli Barzilay
2010-05-05 21:24 ` Jonathan Nieder [this message]
2010-05-05 21:28 ` Re-submitting patches Eli Barzilay
2010-05-05 21:31 ` [PATCH v2] An alias that starts with "!!" runs in the current directory Eli Barzilay
2010-05-05 22:22 ` Will Palmer
2010-05-05 22:33 ` Eli Barzilay
2010-05-05 23:43 ` Junio C Hamano
2010-05-06 0:05 ` Adam Brewster
2010-05-06 6:21 ` Will Palmer
2010-05-06 6:26 ` Will Palmer
2010-05-06 6:36 ` Johannes Sixt
2010-05-06 7:02 ` Matthieu Moy
2010-05-05 22:02 ` [PATCH] " Junio C Hamano
2010-05-05 22:13 ` Eli Barzilay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100505212437.GA26487@progeny.tock \
--to=jrnieder@gmail.com \
--cc=eli@barzilay.org \
--cc=git@vger.kernel.org \
--cc=jaredhance@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).