git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
	Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
	git@vger.kernel.org
Subject: Re: [PATCH/RFC] Add [] as an alias for a reference to the empty tree
Date: Sat, 8 May 2010 11:07:31 -0500	[thread overview]
Message-ID: <20100508160731.GA4638@progeny.tock> (raw)
In-Reply-To: <7vhbmjc6dy.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> The reason I am not interested in the feature
> is because I don't see much value in running "git diff EMPTY <anything>".
> Perhaps "git archive" might be what the user really wants to find.

I suspect the goal was to use a tool such as checkpatch, or
get_maintainer without -f.  An implementation using git archive should
still work (with the help of a tar diff-ing program with the EMPTY
feature ;-)), but as UI that might be less discoverable than building
it into git diff.

Personally, I liked both the

  git diff $(</dev/null git hash-object -t tree --stdin) $rev

and

  git diff --root $rev

suggestions.  That may be from a warped sense of aesthetics.

Cheers,
Jonathan

  parent reply	other threads:[~2010-05-08 16:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-07 16:37 [PATCH/RFC] Add [] as an alias for a reference to the empty tree Peter Kjellerstedt
2010-05-08  4:53 ` Jeff King
2010-05-08  5:24   ` Junio C Hamano
2010-05-08  5:34     ` Jeff King
2010-05-08 16:07     ` Jonathan Nieder [this message]
2010-05-10  8:14     ` Peter Kjellerstedt
2010-05-10  9:20       ` Jeff King
2010-05-10  9:51         ` Sverre Rabbelier
2010-05-10 10:00           ` Jeff King
2010-05-10 11:00             ` Sverre Rabbelier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100508160731.GA4638@progeny.tock \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=peter.kjellerstedt@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).