From: Dmitry Potapov <dpotapov@gmail.com>
To: Finn Arne Gangstad <finnag@pvv.org>
Cc: Eyvind Bernhardsen <eyvind.bernhardsen@gmail.com>,
"git@vger.kernel.org List" <git@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
mat <matthieu.stigler@gmail.com>,
hasen j <hasan.aljudy@gmail.com>,
Erik Faye-Lund <kusmabite@googlemail.com>,
Junio C Hamano <gitster@pobox.com>,
Avery Pennarun <apenwarr@gmail.com>,
Robert Buck <buck.robert.j@gmail.com>
Subject: Re: [PATCH/RFC v2 1/4] Add "core.eolStyle" variable to control end-of-line conversion
Date: Mon, 10 May 2010 12:13:58 +0400 [thread overview]
Message-ID: <20100510081358.GD14069@dpotapov.dyndns.org> (raw)
In-Reply-To: <20100509200935.GA22563@pvv.org>
On Sun, May 09, 2010 at 10:09:37PM +0200, Finn Arne Gangstad wrote:
>
> So maybe, just maybe, we can make everything sufficiently good by
> repairing "core.autocrlf = {input,true}" so that git will not convert
> a CRLF already in the repo. This would make autocrlf = true a safe
> default value (and probably input too, but you'd have to "do
> something" to get a new text file with CRLF into the repo then).
First of autocrlf is safe as it is implemented now. Second, to do
something to get a new with CRLF into the repo is really stupid.
The whole point of autocrlf is being automatic and do not have the
user to worry about CRLF when he adds a new file.
The only real problem I am aware of is that some repository are not
compatible with autocrlf conversion, because they store text files
with different endings and do not have appropriate .gitatributes to
describle what text files should and should not be converted. So, each
user has to disable autocrlf in them manually and then re-checkout all
files using (rm -rf * && git checkout -f), which is confusing for many
users. In fact, you do not have to disable autocrlf, you can add a few
lines to .git/info/attributes to make it autocrlf compatible, but again
many users even not aware about this file, let alone what needs to be
added. Further, the problem amplified by the fact that you have to do
the same procedure every time when you do cloning, and though cloning
is not most common operation, it happens often enough to annoy many
users.
I believe that the right solution is to be able to enable autocrlf but
only for those repositories that are marked as autocrlf compatible by
upstream.
Dmitry
next prev parent reply other threads:[~2010-05-10 8:14 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-08 21:46 [PATCH/RFC v2 0/4] End-of-line normalization, take 2 (now only slightly scary) Eyvind Bernhardsen
2010-05-08 21:46 ` [PATCH/RFC v2 1/4] Add "core.eolStyle" variable to control end-of-line conversion Eyvind Bernhardsen
2010-05-08 21:57 ` Linus Torvalds
2010-05-08 22:17 ` Eyvind Bernhardsen
2010-05-08 22:53 ` Eyvind Bernhardsen
2010-05-08 23:08 ` Linus Torvalds
2010-05-09 8:13 ` Eyvind Bernhardsen
2010-05-09 18:11 ` Linus Torvalds
2010-05-09 20:11 ` Eyvind Bernhardsen
2010-05-09 7:00 ` Dmitry Potapov
2010-05-09 7:30 ` hasen j
2010-05-10 7:16 ` Dmitry Potapov
2010-05-09 8:34 ` Eyvind Bernhardsen
2010-05-09 10:42 ` Eyvind Bernhardsen
2010-05-09 11:14 ` Robert Buck
2010-05-09 18:59 ` Eyvind Bernhardsen
2010-05-09 20:46 ` Robert Buck
2010-05-10 4:33 ` Eyvind Bernhardsen
2010-05-10 11:43 ` Robert Buck
2010-05-10 13:25 ` Robert Buck
2010-05-10 14:03 ` Dmitry Potapov
2010-05-09 17:02 ` Jay Soffian
2010-05-09 17:43 ` Jay Soffian
2010-05-10 18:33 ` Eyvind Bernhardsen
2010-05-09 17:45 ` Junio C Hamano
2010-05-09 18:18 ` Finn Arne Gangstad
2010-05-09 21:57 ` Junio C Hamano
2010-05-10 5:14 ` Eyvind Bernhardsen
2010-05-09 20:25 ` Eyvind Bernhardsen
2010-05-09 20:09 ` Finn Arne Gangstad
2010-05-10 8:13 ` Dmitry Potapov [this message]
2010-05-10 11:14 ` Finn Arne Gangstad
2010-05-10 13:46 ` Dmitry Potapov
2010-05-09 9:21 ` Finn Arne Gangstad
2010-05-08 21:46 ` [PATCH/RFC v2 2/4] Add tests for per-repository eol normalization Eyvind Bernhardsen
2010-05-08 21:46 ` [PATCH/RFC v2 3/4] Pass eol conv mode as an argument instead of using global auto_crlf Eyvind Bernhardsen
2010-05-08 21:46 ` [PATCH/RFC v2 4/4] Add per-repository eol normalization Eyvind Bernhardsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510081358.GD14069@dpotapov.dyndns.org \
--to=dpotapov@gmail.com \
--cc=apenwarr@gmail.com \
--cc=buck.robert.j@gmail.com \
--cc=eyvind.bernhardsen@gmail.com \
--cc=finnag@pvv.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hasan.aljudy@gmail.com \
--cc=kusmabite@googlemail.com \
--cc=matthieu.stigler@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).