From: Jeff King <peff@peff.net>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH/RFC] Add [] as an alias for a reference to the empty tree
Date: Mon, 10 May 2010 05:20:54 -0400 [thread overview]
Message-ID: <20100510092054.GA2602@coredump.intra.peff.net> (raw)
In-Reply-To: <A612847CFE53224C91B23E3A5B48BAC74482E511E7@xmail3.se.axis.com>
On Mon, May 10, 2010 at 10:14:15AM +0200, Peter Kjellerstedt wrote:
> However, if INDEX, WORKTREE and EMPTY are preferred as syntactic sugar
> tokes, then that is fine by me. Unfortunately, I do not have the time
> nor the knowledge needed to add support for the INDEX and WORKTREE
> tokens, so I am afraid I will have to leave this as a suggestion for
> the future.
Implementing INDEX and WORKTREE would be quite challenging. EMPTY is
easy because it is really just a fake ref for a particular sha1. The
others need special casing everywhere that might look at the result.
So certainly if you want to do EMPTY, I wouldn't let the lack of the
other two hold you back. The only reason they are related at all is that
they would probably share a syntax, if the other two ever even get
implemented.
-Peff
next prev parent reply other threads:[~2010-05-10 9:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 16:37 [PATCH/RFC] Add [] as an alias for a reference to the empty tree Peter Kjellerstedt
2010-05-08 4:53 ` Jeff King
2010-05-08 5:24 ` Junio C Hamano
2010-05-08 5:34 ` Jeff King
2010-05-08 16:07 ` Jonathan Nieder
2010-05-10 8:14 ` Peter Kjellerstedt
2010-05-10 9:20 ` Jeff King [this message]
2010-05-10 9:51 ` Sverre Rabbelier
2010-05-10 10:00 ` Jeff King
2010-05-10 11:00 ` Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510092054.GA2602@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).