From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Tay Ray Chuan <rctay89@gmail.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
David Michael Barr <david.barr@cordelta.com>
Subject: Re: [WIP PATCH] Add skeleton remote helper for SVN
Date: Mon, 10 May 2010 07:59:53 -0500 [thread overview]
Message-ID: <20100510125953.GA5642@progeny.tock> (raw)
In-Reply-To: <AANLkTikFl25Hay7UEvsz5bsdg8fdT8485SxqgAZXCYqd@mail.gmail.com>
Hi Ram,
Ramkumar Ramachandra wrote:
> It'll be good if Jonathan's patch makes it to `master` by
> then, but I don't think I should prematurely rebase on patches that
> aren't in `master` yet.
Since the conflict resolution is trivial, I agree. When there is an
actual dependency between patches, I think there is nothing wrong
with basing one patch on another; as long as you make it clear
what your patch applies to, humans and Junio’s scripts can cope with
the task of applying one series on top of the topic branch for
another.
Re your skeleton code, it looks reasonable to me. I could nitpick the
names of the import_handler() and export_handler() functions and the
needless use of do ... while, but I will refrain. :)
Much more importantly, there is something to play with now. On that
note, is David’s code out there somewhere for people to fool around
with? At this point, I am not interested in a stable interface or
permanent history, just a way to try out the code and start to get
used to it.
Thanks,
Jonathan
[1] git://repo.or.cz/svn-all-fast-export.git
next prev parent reply other threads:[~2010-05-10 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 11:39 [WIP PATCH] Write stubby remote helper for SVN Ramkumar Ramachandra
2010-05-10 11:39 ` [WIP PATCH] Add skeleton " Ramkumar Ramachandra
2010-05-10 12:00 ` Tay Ray Chuan
2010-05-10 12:31 ` Ramkumar Ramachandra
2010-05-10 12:59 ` Jonathan Nieder [this message]
2010-05-10 13:08 ` Ramkumar Ramachandra
2010-05-10 13:21 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510125953.GA5642@progeny.tock \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=david.barr@cordelta.com \
--cc=git@vger.kernel.org \
--cc=rctay89@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).