From: Thomas Rast <trast@student.ethz.ch>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: <git@vger.kernel.org>, Johan Herland <johan@herland.net>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 4/8] Documentation/notes: simplify treatment of default notes ref
Date: Wed, 12 May 2010 09:46:30 +0200 [thread overview]
Message-ID: <201005120946.31193.trast@student.ethz.ch> (raw)
In-Reply-To: <20100509032358.GD7958@progeny.tock>
Jonathan Nieder wrote:
> @@ -187,13 +190,10 @@ CONFIGURATION
> -------------
>
> core.notesRef::
> - When showing commit messages, also show notes which are stored in
> - the given ref. The ref must be fully qualified. If the given
> - ref does not exist, it is not an error but means that no
> - notes should be printed.
> -+
> -This setting defaults to "refs/notes/commits", and it can be overridden by
> -the 'GIT_NOTES_REF' environment variable. See linkgit:git-notes[1].
> + Notes ref to read and manipulate instead of
> + `refs/notes/commits`. Must be an unabbreviated ref name.
> + This setting can be overridden through the environment and
> + command line.
In the end result, this makes core.notesRef the only configuration
variable which does not have its environment sibling named explicitly
in the config section. Would you mind putting GIT_NOTES_REF back in
the sentence for consistency with the other variables?
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-05-12 7:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-09 3:13 [PATCH v2 0/8] filling out the notes man page Jonathan Nieder
2010-05-09 3:19 ` [PATCH 1/8] Documentation/notes: document format of notes trees Jonathan Nieder
2010-05-09 6:52 ` Jeff King
2010-05-09 3:21 ` [PATCH 2/8] Documentation/notes: describe content of notes blobs Jonathan Nieder
2010-05-09 3:21 ` [PATCH 3/8] Documentation/notes: add configuration section Jonathan Nieder
2010-05-09 3:23 ` [PATCH 4/8] Documentation/notes: simplify treatment of default notes ref Jonathan Nieder
2010-05-12 7:46 ` Thomas Rast [this message]
2010-05-12 10:28 ` Jonathan Nieder
2010-05-09 3:30 ` [PATCH 5/8] Documentation/log: add a CONFIGURATION section Jonathan Nieder
2010-05-09 6:57 ` Jeff King
2010-05-09 3:32 ` [PATCH 6/8] Documentation/notes: simplify treatment of default display refs Jonathan Nieder
2010-05-09 7:00 ` Jeff King
2010-05-09 8:43 ` Jonathan Nieder
2010-05-10 6:06 ` Jeff King
2010-05-12 10:50 ` Jonathan Nieder
2010-05-12 11:23 ` Jeff King
2010-05-09 3:33 ` [PATCH 7/8] Documentation/notes: clean up description of rewriting configuration Jonathan Nieder
2010-05-09 3:37 ` [PATCH 8/8] Documentation/notes: nitpicks Jonathan Nieder
2010-05-10 23:27 ` [PATCH v2 0/8] filling out the notes man page Johan Herland
2010-05-12 7:48 ` Thomas Rast
2010-05-12 12:57 ` [PATCH v3] Documentation/notes: fill out the man page a little Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005120946.31193.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).