From: Jeff King <peff@peff.net>
To: Eli Barzilay <eli@barzilay.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Eugene Sajine <euguess@gmail.com>,
Bo Yang <struggleyb.nku@gmail.com>,
Jacob Helwig <jacob.helwig@gmail.com>,
git@vger.kernel.org
Subject: Re: Re: git log -M -- filename is not working?
Date: Wed, 12 May 2010 09:03:39 -0400 [thread overview]
Message-ID: <20100512130339.GA19072@coredump.intra.peff.net> (raw)
In-Reply-To: <20100512124948.GA11761@coredump.intra.peff.net>
On Wed, May 12, 2010 at 08:49:48AM -0400, Jeff King wrote:
> Anyway, here is the patch. My testing so far has been very simple, so
> please try it on a few repos and let me know if it does what you expect
> in all cases. Note that is based on "next", as it has Bo's
> find_copies_harder patch.
By the way, here are some basic speed tests in git.git:
$ time git log builtin >/dev/null
real 0m0.486s
user 0m0.468s
sys 0m0.016s
$ time git log --follow builtin >/dev/null
real 0m23.518s
user 0m23.469s
sys 0m0.040s
So it's _way_ slower, but still snappy enough with the first few commits
not to be awful. However, I haven't done any profiling, so it may be
that we can improve that by limiting the rename-detection diff only to
interesting paths.
-Peff
next prev parent reply other threads:[~2010-05-12 13:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 18:07 git log -M -- filename is not working? Eugene Sajine
2010-05-07 18:10 ` Jacob Helwig
2010-05-07 18:31 ` Eugene Sajine
2010-05-07 18:37 ` Eli Barzilay
2010-05-07 20:25 ` Matthieu Moy
2010-05-07 20:28 ` Jakub Narebski
2010-05-08 4:44 ` Jeff King
2010-05-08 5:12 ` Eli Barzilay
2010-05-08 5:30 ` Jeff King
2010-05-08 5:39 ` Junio C Hamano
2010-05-08 7:08 ` Eli Barzilay
2010-05-12 11:38 ` Jeff King
2010-05-12 12:01 ` Eli Barzilay
2010-05-12 12:49 ` Jeff King
2010-05-12 13:03 ` Jeff King [this message]
2010-05-12 14:35 ` Eli Barzilay
2010-05-12 16:07 ` Bo Yang
2010-05-12 16:45 ` Jeff King
2010-05-13 2:12 ` Bo Yang
2010-05-13 4:39 ` Eli Barzilay
2010-05-14 4:55 ` Jeff King
2010-05-14 5:05 ` Eli Barzilay
2010-05-12 13:06 ` Bo Yang
2010-05-12 13:09 ` Jeff King
2010-05-12 14:42 ` Eli Barzilay
2010-05-12 14:49 ` Bo Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512130339.GA19072@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=eli@barzilay.org \
--cc=euguess@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.helwig@gmail.com \
--cc=struggleyb.nku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).