git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Knittl <knittl89@googlemail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Show branch information in short output of git status
Date: Wed, 12 May 2010 09:35:38 -0400	[thread overview]
Message-ID: <20100512133537.GA28956@coredump.intra.peff.net> (raw)
In-Reply-To: <AANLkTikDkrNrzPmIhmcBRKtLKV70f4Kp8wTw6I6ctB4O@mail.gmail.com>

On Thu, May 06, 2010 at 02:24:41PM +0200, Knittl wrote:

>  - initial commit is also printed when there is tracking information
> (i still haven't managed to create a situation like that. `git branch
> oldmaster; rm .git/refs/heads/master; git branch master --set-upstream
> oldmaster` will reset branch master to oldmaster (a bug?))

Try:

  git branch oldmaster
  rm .git/refs/heads/master
  git config branch.master.remote .
  git config branch.master.merge refs/heads/oldmaster

That being said, I still get "Initial commit on master". I think that
stat_tracking_branch just gives up if the branch doesn't exist (which
does make some sense). So in practice, I think your original and this
one actually behave the same (sorry, I know that changing it was my
suggestion).

And no, the "--set-upstream" behavior is not a bug. At least not
according to the documentation. ;)

>  - colors to match output of `git branch` (green: current, red: remote)
>  - output format is copy-pasteable, ahead/behind information is in the
> same format as in `git branch -v`

I think it's much nicer, though the colors are a bit much for my liking.
Still, it's configurable, so I don't have to care. :)

>  - branch information is still printed by default, i have to look into
> commandline option parsing first. i was thinking of `git status -v -b`
> (as in `git checkout -b` to mean branch)

You may also want to have a configuration option if it is the output you
prefer all the time (similarly, if you are using "git status -s" all the
time, you might want a config option to make "git status" do what you
want).

> ---------8<----------------
> From 82b4481d38ae0cd62030aeea67160656b7c763e2 Mon Sep 17 00:00:00 2001
> From: Daniel Knittl-Frank <knittl89+git@googlemail.com>
> Date: Tue, 20 Apr 2010 22:40:54 +0200
> Subject: [PATCH] Show branch information in short output of git status

This patch looks OK, but:

  1. I think for the final version you can just squash in part 2/2.

  2. Your patch has wrapped lines which make it impossible to apply
     without fixing up manually. This is a common gmail problem.  See
     the "gmail" section of SubmittingPatches.

-Peff

  parent reply	other threads:[~2010-05-12 13:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-02  9:13 [PATCH] Show branch information in short output of git status Knittl
2010-05-05  5:06 ` Jeff King
2010-05-06 12:24   ` Knittl
2010-05-07 16:05     ` Knittl
2010-05-12 13:35     ` Jeff King [this message]
2010-05-14  6:54       ` Knittl
2010-05-23  9:23         ` Jeff King
2010-05-25  7:19           ` Michael J Gruber
2010-05-25  7:22             ` Jeff King
2010-05-25  8:10               ` Michael J Gruber
2010-05-25  8:30               ` [PATCH] Documentation/SubmittingPatches: clarify GMail section and SMTP Michael J Gruber
2010-05-25  9:25                 ` Jeff King
2010-05-25  9:47                   ` Ævar Arnfjörð Bjarmason
  -- strict thread matches above, loose matches on Subject: below --
2010-05-02 10:10 [PATCH] Show branch information in short output of git status Knittl
     [not found] <AANLkTinNYcuiyRpgMGpQAEaStj2MDg9UooozooLPwv_0@mail.gmail.com>
2010-05-25 13:45 ` Michael J Gruber
2010-05-25 14:03   ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100512133537.GA28956@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=knittl89@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).