From: "Gary V. Vaughan" <git@mlists.thewrittenword.com>
To: git@vger.kernel.org
Subject: [PATCH v5 05/18] Do not use "diff" found on PATH while building and installing
Date: Fri, 14 May 2010 09:31:36 +0000 [thread overview]
Message-ID: <20100514093746.689775000@mlists.thewrittenword.com> (raw)
In-Reply-To: 20100514093131.249094000@mlists.thewrittenword.com
[-- Attachment #1: diff-export.patch --]
[-- Type: text/plain, Size: 3108 bytes --]
Some of the flags used with the first diff found in PATH cause the
vendor diff to choke.
Signed-off-by: Gary V. Vaughan <gary@thewrittenword.com>
---
Documentation/install-webdoc.sh | 2 +-
Makefile | 4 +++-
config.mak.in | 1 +
configure.ac | 1 +
git-merge-one-file.sh | 2 +-
5 files changed, 7 insertions(+), 3 deletions(-)
Index: b/Makefile
===================================================================
--- a/Makefile
+++ b/Makefile
@@ -287,6 +287,7 @@ export prefix bindir sharedir sysconfdir
CC = gcc
AR = ar
RM = rm -f
+DIFF = diff
TAR = tar
FIND = find
INSTALL = install
@@ -1460,7 +1461,7 @@ endif
ALL_CFLAGS += $(BASIC_CFLAGS)
ALL_LDFLAGS += $(BASIC_LDFLAGS)
-export TAR INSTALL DESTDIR SHELL_PATH
+export DIFF TAR INSTALL DESTDIR SHELL_PATH
### Build rules
@@ -1877,6 +1878,7 @@ GIT-CFLAGS: FORCE
GIT-BUILD-OPTIONS: FORCE
@echo SHELL_PATH=\''$(subst ','\'',$(SHELL_PATH_SQ))'\' >$@
@echo PERL_PATH=\''$(subst ','\'',$(PERL_PATH_SQ))'\' >>$@
+ @echo DIFF=\''$(subst ','\'',$(subst ','\'',$(DIFF)))'\' >>$@
@echo TAR=\''$(subst ','\'',$(subst ','\'',$(TAR)))'\' >>$@
@echo NO_CURL=\''$(subst ','\'',$(subst ','\'',$(NO_CURL)))'\' >>$@
@echo NO_PERL=\''$(subst ','\'',$(subst ','\'',$(NO_PERL)))'\' >>$@
Index: b/configure.ac
===================================================================
--- a/configure.ac
+++ b/configure.ac
@@ -362,6 +362,7 @@ fi
#AC_PROG_INSTALL # needs install-sh or install.sh in sources
AC_CHECK_TOOLS(AR, [gar ar], :)
AC_CHECK_PROGS(TAR, [gtar tar])
+AC_CHECK_PROGS(DIFF, [gnudiff gdiff diff])
# TCLTK_PATH will be set to some value if we want Tcl/Tk
# or will be empty otherwise.
if test -z "$NO_TCLTK"; then
Index: b/Documentation/install-webdoc.sh
===================================================================
--- a/Documentation/install-webdoc.sh
+++ b/Documentation/install-webdoc.sh
@@ -12,7 +12,7 @@ do
then
: did not match
elif test -f "$T/$h" &&
- diff -u -I'Last updated [0-9][0-9]-[A-Z][a-z][a-z]-' "$T/$h" "$h"
+ $DIFF -u -I'Last updated [0-9][0-9]-[A-Z][a-z][a-z]-' "$T/$h" "$h"
then
:; # up to date
else
Index: b/git-merge-one-file.sh
===================================================================
--- a/git-merge-one-file.sh
+++ b/git-merge-one-file.sh
@@ -107,7 +107,7 @@ case "${1:-.}${2:-.}${3:-.}" in
# remove lines that are unique to ours.
orig=`git-unpack-file $2`
sz0=`wc -c <"$orig"`
- diff -u -La/$orig -Lb/$orig $orig $src2 | git apply --no-add
+ $DIFF -u -La/$orig -Lb/$orig $orig $src2 | git apply --no-add
sz1=`wc -c <"$orig"`
# If we do not have enough common material, it is not
Index: b/config.mak.in
===================================================================
--- a/config.mak.in
+++ b/config.mak.in
@@ -8,6 +8,7 @@ LDFLAGS = @LDFLAGS@
CC_LD_DYNPATH = @CC_LD_DYNPATH@
AR = @AR@
TAR = @TAR@
+DIFF = @DIFF@
#INSTALL = @INSTALL@ # needs install-sh or install.sh in sources
TCLTK_PATH = @TCLTK_PATH@
--
Gary V. Vaughan (gary@thewrittenword.com)
next prev parent reply other threads:[~2010-05-14 9:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 9:31 [PATCH v5 00/18] Portability patches for git-1.7.1 Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 01/18] Makefile: pass CPPFLAGS through to fllow customization Gary V. Vaughan
2010-05-14 9:53 ` Robin H. Johnson
2010-05-14 10:58 ` Gary V. Vaughan
2010-05-14 11:04 ` Robin H. Johnson
2010-05-14 12:01 ` Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 02/18] Rewrite dynamic structure initializations to runtime assignment Gary V. Vaughan
2010-06-02 4:39 ` Junio C Hamano
2010-05-14 9:31 ` [PATCH v5 03/18] Makefile: -lpthread may still be necessary when libc has only pthread stubs Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 04/18] enums: omit trailing comma for portability Gary V. Vaughan
2010-05-14 9:31 ` Gary V. Vaughan [this message]
2010-06-02 4:39 ` [PATCH v5 05/18] Do not use "diff" found on PATH while building and installing Junio C Hamano
2010-05-14 9:31 ` [PATCH v5 06/18] tests: use "test_cmp", not "diff", when verifying the result Gary V. Vaughan
2010-06-02 4:39 ` Junio C Hamano
2010-05-14 9:31 ` [PATCH v5 07/18] test_cmp: do not use "diff -u" on platforms that lack one Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 08/18] git-compat-util.h: some platforms with mmap() lack MAP_FAILED definition Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 09/18] Makefile: some platforms do not have hstrerror anywhere Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 10/18] Make NO_{INET_NTOP,INET_PTON} configured independently Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 11/18] Some platforms lack socklen_t type Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 12/18] Allow disabling "inline" Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 13/18] inline declaration does not work on AIX Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 14/18] Makefile: SunOS 5.6 portability fix Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 15/18] git-compat-util.h: Irix 6.5 defines sgi but not __sgi Gary V. Vaughan
2010-06-02 1:55 ` [PATCH] git-compat-util.h: use apparently more common __sgi macro to detect SGI IRIX Brandon Casey
2010-06-02 8:43 ` Gary V. Vaughan
2010-06-02 9:56 ` Tor Arntsen
2010-05-14 9:31 ` [PATCH v5 16/18] Makefile: HPUX11 portability fixes Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 17/18] Makefile: HP-UX 10.20 " Gary V. Vaughan
2010-05-14 9:31 ` [PATCH v5 18/18] Makefile: Tru64 portability fix Gary V. Vaughan
2010-05-26 5:56 ` [PATCH v5 00/18] Portability patches for git-1.7.1 Gary V. Vaughan
2010-06-07 15:45 ` Gary V. Vaughan
2010-06-07 18:07 ` Junio C Hamano
2010-06-09 9:37 ` Tor Arntsen
2010-06-11 4:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514093746.689775000@mlists.thewrittenword.com \
--to=git@mlists.thewrittenword.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).