From: Jakub Narebski <jnareb@gmail.com>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Cc: Git List <git@vger.kernel.org>, Petr Baudis <pasky@ucw.cz>,
Christian Couder <chriscool@tuxfamily.org>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH GSoC] gitweb: Add global installation target for gitweb
Date: Sat, 15 May 2010 20:43:04 +0200 [thread overview]
Message-ID: <201005152043.05698.jnareb@gmail.com> (raw)
In-Reply-To: <AANLkTilxlnUdfGEvpsaIKm3waSTGH_jUG9pW8ozc1PUJ@mail.gmail.com>
On Sat, 15 May 2010, Pavan Kumar Sunkara wrote:
> So, what I need to do in this patch is add default values. Not
> installing in 'install' target. ??
> Or any thing else.
>
> If you could specify what needs to be done, I will be happy resend
> the patch.
To get my ACK for this patch it is enough to *not* add installing gitweb
to 'install' target in main Makefile. IMVHO it should be left for next
patch in this series.
P.S. By the way, you should write in comments to patch, i.e. between
"---" separator and the diffstat, that this patch is based on 'next'
branch, or perhaps even that it is based on commit 152d943 in
'jn/gitweb-install'.
>From Documentation/SubmittingChanges:
If you are preparing a work based on "next" branch, that is fine,
but please mark it as such.
^^^^^^^^^^^^^^^
Keep up good work!
--
Jakub Narebski
Poland
prev parent reply other threads:[~2010-05-15 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 9:38 [PATCH GSoC] gitweb: Add global installation target for gitweb Pavan Kumar Sunkara
2010-05-14 15:07 ` Jakub Narebski
2010-05-14 16:40 ` Pavan Kumar Sunkara
2010-05-14 21:22 ` Jakub Narebski
2010-05-15 12:49 ` Jakub Narebski
2010-05-15 13:04 ` Pavan Kumar Sunkara
2010-05-15 18:43 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005152043.05698.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=pasky@ucw.cz \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).