git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Potapov <dpotapov@gmail.com>
To: Tait <git.git@t41t.com>
Cc: "git@vger.kernel.org List" <git@vger.kernel.org>,
	Eyvind Bernhardsen <eyvind.bernhardsen@gmail.com>,
	Robert Buck <buck.robert.j@gmail.com>
Subject: Re: utf8 BOM
Date: Sun, 16 May 2010 17:32:59 +0400	[thread overview]
Message-ID: <20100516133259.GC17200@dpotapov.dyndns.org> (raw)
In-Reply-To: <20100516112612.GV2480@ece.pdx.edu>

On Sun, May 16, 2010 at 04:26:12AM -0700, Tait wrote:
> > Okay, so something that checks text files to see if they're utf...
> > "core.autoutf", anyone?
> 
> This (and crlf-conversion, for that matter) strikes me as something best 
> handled outside of git core, such as through checkout/commit hooks. Perhaps 
> examples of such hooks could be provided and adapted by each project and 
> user as that user/project sees fit for their specific choice of repository 
> format and development environment.

There are a few problems with using filters for crlf conversion:

1. It is a way too slow... Running a script for each file is in a repo
is even slow on Linux, and on Windows, it is going to be horrible slow.

2. You have to install this filter in every clone, and by the time when
you install it, your repository is already checked out with the wrong
ending. So, you need to fix it.

While using scripts is good where you need flexibility, it is not the
case with crlf conversion.  Users want it to just work, and they want
simple and easy to understand rules how to mark what files should and
should not be converted. If every project is going with itw own rules
and scripts, it is going to be a big mess.

Now, when we speak about charset encoding, it could make sense to try
this new feature as a filter, but if it is something that is to be used
widely, it should be eventually re-written in C.


Dmitry

  reply	other threads:[~2010-05-16 13:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-12 23:00 [PATCH v3 0/5] End-of-line normalization, redesigned Eyvind Bernhardsen
2010-05-12 23:00 ` [PATCH v3 1/5] autocrlf: Make it work also for un-normalized repositories Eyvind Bernhardsen
2010-05-12 23:00 ` [PATCH v3 2/5] Add tests for per-repository eol normalization Eyvind Bernhardsen
2010-05-12 23:00 ` [PATCH v3 3/5] Add " Eyvind Bernhardsen
2010-05-12 23:00 ` [RFC/PATCH v3 4/5] Rename "crlf" attribute as "eolconv" Eyvind Bernhardsen
2010-05-13  1:38   ` Linus Torvalds
2010-05-13  9:39     ` Robert Buck
2010-05-13  9:58       ` Robert Buck
2010-05-13 11:47         ` Eyvind Bernhardsen
2010-05-13 13:19           ` Robert Buck
2010-05-14 10:16           ` utf8 BOM Dmitry Potapov
2010-05-15 20:23             ` Eyvind Bernhardsen
2010-05-16  5:19               ` Dmitry Potapov
2010-05-16 10:37                 ` Eyvind Bernhardsen
2010-05-16 11:26                   ` Tait
2010-05-16 13:32                     ` Dmitry Potapov [this message]
2010-05-13 10:59     ` [RFC/PATCH v3 4/5] Rename "crlf" attribute as "eolconv" Eyvind Bernhardsen
2010-05-13 21:45       ` Linus Torvalds
2010-05-14  2:34         ` Robert Buck
2010-05-14  4:56           ` Jonathan Nieder
2010-05-14 21:21             ` Eyvind Bernhardsen
2010-05-14 21:32           ` Eyvind Bernhardsen
2010-05-14 21:16         ` Eyvind Bernhardsen
2010-05-14 21:27           ` Linus Torvalds
2010-05-15 20:47             ` [PATCH] Add "core.eol" variable to control end-of-line conversion Eyvind Bernhardsen
2010-05-16 10:39               ` Robert Buck
2010-05-12 23:00 ` [RFC/PATCH v3 5/5] Rename "core.autocrlf" config variable as "core.eolconv" Eyvind Bernhardsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100516133259.GC17200@dpotapov.dyndns.org \
    --to=dpotapov@gmail.com \
    --cc=buck.robert.j@gmail.com \
    --cc=eyvind.bernhardsen@gmail.com \
    --cc=git.git@t41t.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).