From: Thomas Rast <trast@student.ethz.ch>
To: Bo Yang <struggleyb.nku@gmail.com>
Cc: <git@vger.kernel.org>, <gitster@pobox.com>
Subject: Re: [PATCH 4/7] diff.c: Output the text graph padding before each diff line.
Date: Mon, 17 May 2010 08:52:31 +0200 [thread overview]
Message-ID: <201005170852.31546.trast@student.ethz.ch> (raw)
In-Reply-To: <1273921331-32702-5-git-send-email-struggleyb.nku@gmail.com>
Bo Yang wrote:
> diff --git a/diff.c b/diff.c
> index 9bd9063..4a10d16 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -487,6 +487,13 @@ static void emit_rewrite_diff(const char *name_a,
> char *data_one, *data_two;
> size_t size_one, size_two;
> struct emit_callback ecbdata;
> + char *line_prefix = "";
> + struct strbuf *msgbuf;
> +
> + if (o && o->output_prefix) {
> + msgbuf = o->output_prefix(o->file, 0, o->output_prefix_data);
> + line_prefix = msgbuf->buf;
> + }
Umm. This snippet of code means that the callback can't to much
except return or print a string depending on the value of the second
argument, doesn't it?
So why not either make it explicit and just put a char* field there,
or make a more generic callback that replaces write() (or so) and
gets a chance to mangle the output in any way it likes?
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-05-17 6:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 11:02 [PATCH 0/7] Make git log --graph looks better with -p and other diff options Bo Yang
2010-05-15 11:02 ` [PATCH 1/7] Add a prefix output callback to diff output Bo Yang
2010-05-15 11:02 ` [PATCH 2/7] Change to call the new emit_line Bo Yang
2010-05-15 11:02 ` [PATCH 3/7] Output the graph columns at the end of the commit message Bo Yang
2010-05-15 11:02 ` [PATCH 4/7] diff.c: Output the text graph padding before each diff line Bo Yang
2010-05-15 11:02 ` [PATCH 5/7] Emit a whole line once a time Bo Yang
2010-05-15 11:02 ` [PATCH 6/7] Register a callback for graph output Bo Yang
2010-05-15 11:02 ` [PATCH 7/7] Make --color-words work well with --graph Bo Yang
2010-05-17 6:59 ` Thomas Rast
2010-05-17 6:57 ` [PATCH 6/7] Register a callback for graph output Thomas Rast
2010-05-17 6:52 ` Thomas Rast [this message]
2010-05-17 6:45 ` [PATCH 2/7] Change to call the new emit_line Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005170852.31546.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=struggleyb.nku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).