From: Jeff King <peff@peff.net>
To: Bo Yang <struggleyb.nku@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, trast@student.ethz.ch
Subject: Re: [PATCH 0/6 v2] Make git log --graph looks better with -p and other diff options
Date: Thu, 20 May 2010 08:36:50 -0400 [thread overview]
Message-ID: <20100520123650.GA7665@sigill.intra.peff.net> (raw)
In-Reply-To: <1274351138-11813-1-git-send-email-struggleyb.nku@gmail.com>
On Thu, May 20, 2010 at 03:25:32AM -0700, Bo Yang wrote:
> When we run git log --graph with any other diff output function, such as '-p','--check','--numstat' or other diff optoins, the diff output area have no graph lines ahead of it. And this make the text graph looks strange.
> The following 7 patches try to deal with this, and put the text graph
> columns before all the diff output lines.
This is very cool. "git log --graph --oneline --stat" is interesting to
see. It seems to work fine with "-p", "--stat", and "--raw". But try:
git log --graph --oneline --summary 212f0ba
Summary lines for some reason don't get properly indented or prefixed
with branch lines.
-Peff
next prev parent reply other threads:[~2010-05-20 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 10:25 [PATCH 0/6 v2] Make git log --graph looks better with -p and other diff options Bo Yang
2010-05-20 10:25 ` [PATCH 1/6 v2] Add a prefix output callback to diff output Bo Yang
2010-05-20 10:25 ` [PATCH 2/6 v2] Output the graph columns at the end of the commit message Bo Yang
2010-05-20 10:25 ` [PATCH 3/6 v2] diff.c: Output the text graph padding before each diff line Bo Yang
2010-05-20 10:25 ` [PATCH 4/6 v2] Emit a whole line once a time Bo Yang
2010-05-20 10:25 ` [PATCH 5/6 v2] Register a callback for graph output Bo Yang
2010-05-20 10:25 ` [PATCH 6/6 v2] Make --color-words work well with --graph Bo Yang
2010-05-20 12:36 ` Jeff King [this message]
2010-05-20 13:24 ` [PATCH 0/6 v2] Make git log --graph looks better with -p and other diff options Jeff King
2010-05-21 1:49 ` Bo Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520123650.GA7665@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=struggleyb.nku@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).