From: Jakub Narebski <jnareb@gmail.com>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Cc: git@vger.kernel.org, Eric Wong <normalperson@yhbt.net>,
Christian Couder <chriscool@tuxfamily.org>,
Petr Baudis <pasky@ucw.cz>
Subject: Re: [PATCHv2 GSoC] git-instaweb: Configure it to work with new gitweb structure
Date: Sat, 22 May 2010 20:59:54 +0200 [thread overview]
Message-ID: <201005222059.54995.jnareb@gmail.com> (raw)
In-Reply-To: <AANLkTinbzlRsmQekpLlFQC3xOMB2ZUurLqJoyFCnHZFG@mail.gmail.com>
On Sat, 22 May 2010, Pavan Kumar Sunkara wrote:
> 2010/5/22 Jakub Narebski <jnareb@gmail.com>:
>> On Sat, 22 May 2010, Pavan Kumar Sunkara wrote:
>> Acked-by: Jakub Narebski <jnareb@gmail.com>
>>
>> _If_ there is no problem with $(gitwebdir) and not $(gitwebdir_SQ),
>> see below for details.
[...]
>>> diff --git a/Makefile b/Makefile
>>> index caf2f64..91cd726 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -1592,15 +1592,8 @@ git-instaweb: git-instaweb.sh gitweb/gitweb.cgi gitweb/static/gitweb.css gitweb/
>>> sed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \
>> [...]
>>> + -e 's|@@GITWEBDIR@@|$(gitwebdir)|g' \
>>> -e 's|@@PERL@@|$(PERL_PATH_SQ)|g' \
>>> - -e 's|@@GITWEB_CSS_NAME@@|$(GITWEB_CSS)|' \
>>> - -e 's|@@GITWEB_JS_NAME@@|$(GITWEB_JS)|' \
>>> $@.sh> $@+ && \
>>> chmod +x $@+ && \
>>> mv $@+ $@
>>> @@ -1972,6 +1965,7 @@ install: all
>>> $(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install
>>> ifndef NO_PERL
>>> $(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install
>>> + $(MAKE) -C gitweb gitwebdir=$(gitwebdir) install
>>> endif
>>
>> Have you checked that you can use $(gitwebdir) and don't need
>> $(gitwebdir_SQ) here? Does git-instaweb installs and works correctly
>> if 'gitwebdir' contains spaces and single or double quote characters?
>> But perhaps that doesn't matter in practice, and this is good enough.
>
> Nope. I didn't check it. But you are right.
Does it mean that after your patch git-instaweb works correctly if
'gitwebdir' is set to something like (for example):
gitwebdir="/home/local/some strange \"path'"
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-05-22 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 10:11 [PATCHv2 GSoC] git-instaweb: Configure it to work with new gitweb structure Pavan Kumar Sunkara
2010-05-22 15:57 ` Jakub Narebski
2010-05-22 16:57 ` Pavan Kumar Sunkara
2010-05-22 18:59 ` Jakub Narebski [this message]
2010-05-22 19:18 ` Pavan Kumar Sunkara
2010-05-22 19:56 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005222059.54995.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=pasky@ucw.cz \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).