git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] diff: Support visibility modifiers in the PHP hunk header regexp
@ 2010-05-23 18:05 Björn Steinbrink
  0 siblings, 0 replies; only message in thread
From: Björn Steinbrink @ 2010-05-23 18:05 UTC (permalink / raw)
  To: git

Starting with PHP5, class methods can have a visibility modifier, which
caused the methods not to be matched by the existing regexp, so extend
the regexp to match those modifiers. And while we're at it, allow the
"static" modifier as well.

Since the "static" modifier can appear either before or after the
visibility modifier, let's just allow any number of modifiers to appear
in any order, as that simplifies the regexp and shouldn't cause any
false positives.

Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
---
 userdiff.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/userdiff.c b/userdiff.c
index 67003fb..c49cc1b 100644
--- a/userdiff.c
+++ b/userdiff.c
@@ -45,7 +45,9 @@ PATTERNS("pascal",
 	 "|[-+0-9.e]+|0[xXbB]?[0-9a-fA-F]+"
 	 "|<>|<=|>=|:=|\\.\\."
 	 "|[^[:space:]]|[\x80-\xff]+"),
-PATTERNS("php", "^[\t ]*((function|class).*)",
+PATTERNS("php",
+	 "^[\t ]*(((public|protected|private|static)[\t ]+)*function.*)$\n"
+	 "^[\t ]*(class.*)$",
 	 /* -- */
 	 "[a-zA-Z_][a-zA-Z0-9_]*"
 	 "|[-+0-9.e]+|0[xXbB]?[0-9a-fA-F]+"
-- 
1.7.1.227.g12cb1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-05-23 18:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-23 18:05 [PATCH] diff: Support visibility modifiers in the PHP hunk header regexp Björn Steinbrink

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).