git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Cc: git@vger.kernel.org, jnareb@gmail.com, normalperson@yhbt.net,
	pasky@ucw.cz
Subject: Re: [PATCHv5 GSoC] gitweb: Move static files into seperate subdirectory
Date: Mon, 24 May 2010 22:05:43 +0200	[thread overview]
Message-ID: <201005242205.43194.chriscool@tuxfamily.org> (raw)
In-Reply-To: <1274714564-7553-1-git-send-email-pavan.sss1991@gmail.com>

On Monday 24 May 2010 17:22:44 Pavan Kumar Sunkara wrote:
> 
>  gitweb/{ => static}/git-favicon.png |  Bin 115 -> 115 bytes
>  gitweb/{ => static}/git-logo.png    |  Bin 207 -> 207 bytes
>  gitweb/{ => static}/gitweb.css      |    0
>  gitweb/{ => static}/gitweb.js       |    0

The patch is supposed to move git-favicon.png and git-logo.png into 
gitweb/static but it doesn't.

>  diff --git a/gitweb/gitweb.css b/gitweb/static/gitweb.css
> similarity index 100%
> rename from gitweb/gitweb.css
> rename to gitweb/static/gitweb.css
> diff --git a/gitweb/gitweb.js b/gitweb/static/gitweb.js
> similarity index 100%
> rename from gitweb/gitweb.js
> rename to gitweb/static/gitweb.js

Only gitweb.css and gitweb.js are moved into gitweb/static and that gives some 
errors when running make install:

install -d -m 755 '/home/christian/share/gitweb'
install -m 755 gitweb.cgi '/home/christian/share/gitweb'
install -d -m 755 '/home/christian/share/gitweb/static'
install -m 644 static/gitweb.js static/gitweb.css static/git-logo.png 
static/git-favicon.png '/home/christian/share/gitweb/static'
install: cannot stat `static/git-logo.png': No such file or directory
install: cannot stat `static/git-favicon.png': No such file or directory
make[1]: *** [install] Error 1
make[1]: Leaving directory `/home/christian/work/git/gitweb'
make: *** [install] Error 2

Best regards,
Christian.

  reply	other threads:[~2010-05-24 20:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-24 15:22 [PATCHv5 GSoC] gitweb: Move static files into seperate subdirectory Pavan Kumar Sunkara
2010-05-24 20:05 ` Christian Couder [this message]
2010-05-24 20:28   ` Pavan Kumar Sunkara
2010-05-25  0:37     ` Jakub Narebski
2010-05-25  3:14       ` Christian Couder
2010-05-25  4:30         ` Pavan Kumar Sunkara
2010-05-25  4:24           ` Christian Couder
2010-05-25  4:51             ` Pavan Kumar Sunkara
2010-05-25  6:32               ` Christian Couder
2010-05-25 21:22       ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005242205.43194.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=normalperson@yhbt.net \
    --cc=pasky@ucw.cz \
    --cc=pavan.sss1991@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).