From: Jeff King <peff@peff.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Albert Krawczyk <albert@burgmann.anu.edu.au>, git@vger.kernel.org
Subject: Re: Git log follow question
Date: Tue, 25 May 2010 05:31:40 -0400 [thread overview]
Message-ID: <20100525093140.GA32460@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1005140730030.3711@i5.linux-foundation.org>
On Fri, May 14, 2010 at 07:50:26AM -0700, Linus Torvalds wrote:
> I'm pretty sure I mentioned about this exact issue when I posted the
> original follow patches, and it basically boils down to: "--follow" is a
> total hack, and does _not_ use the regular commit filtering function, and
> as a result, fancy things like "--parent" don't really work well with it.
>
> [...]
>
> And no, I'm unlikely to look at it. Sorry. I have used --follow
> occasionally, but it's a hack to see "ok, there it got renamed". It would
> be nice if "gitk --follow <pathname>" worked properly, but it's just not
> something I care very much about.
Thanks for the input. I took a look at it myself and it is a bit more
complex than just turning on pruning. I have a prototype --follow that
handles arbitrary pathspecs instead of single files; instead of
replacing the single-file pathspec, it just widens the pathspec as it
traverses history. That eliminates some of the issues, but I am still
getting some odd results from --parents.
So I am giving up for now, as it is not something I care that much
about, either (though multiple-file --follow is). However, Bo Yang, one
of the GSoC students, is planning on working on it as part of his
line-level history browsing project. So we'll see what comes of that.
-Peff
next prev parent reply other threads:[~2010-05-25 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 0:57 Git log follow question Albert Krawczyk
2010-05-14 4:16 ` Bo Yang
2010-05-14 4:37 ` Jeff King
2010-05-14 14:50 ` Linus Torvalds
2010-05-14 15:19 ` Martin Langhoff
2010-05-14 15:29 ` Linus Torvalds
[not found] ` <22729_1273851106_4BED6CE2_22729_6897_1_alpine.LFD.2.00.1005140827250.3711@i5.linux-foundation.org>
2010-05-14 22:39 ` Albert Krawczyk
2010-05-25 9:31 ` Jeff King [this message]
2010-05-25 18:49 ` Linus Torvalds
2010-05-26 5:58 ` Jeff King
2010-05-26 14:40 ` Linus Torvalds
[not found] ` <21464_1273811837_4BECD37D_21464_745_1_20100514043704.GC6075@coredump.intra.peff.net>
2010-05-14 4:43 ` Albert Krawczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525093140.GA32460@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=albert@burgmann.anu.edu.au \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).