From: Christian Couder <chriscool@tuxfamily.org>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Cc: pasky@ucw.cz, jnareb@gmail.com
Subject: Re: [PATCH GSoC 1/4] gitweb: Move static files into seperate subdirectory
Date: Fri, 28 May 2010 18:56:27 +0200 [thread overview]
Message-ID: <201005281856.27438.chriscool@tuxfamily.org> (raw)
In-Reply-To: <1275027952-5057-1-git-send-email-pavan.sss1991@gmail.com>
On Friday 28 May 2010 08:25:49 Pavan Kumar Sunkara wrote:
> Create a new subdirectory called 'static' in gitweb/, and move
> all static files required by gitweb.cgi when running, which means
> styles, images and Javascript code. This should make gitweb more
> readable and easier to maintain.
>
> Update t/gitweb-lib.sh to reflect this change.The install-gitweb
> now also include moving of static files into 'static' subdirectory
> in target directory: update Makefile, gitweb's INSTALL, README and
> Makefile accordingly.
>
> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
> Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> Mentored-by: Petr Baudis <pasky@ucw.cz>
> Acked-by: Jakub Narebski <jnareb@gmail.com>
That's nice but you should probably have sent the patch series to Junio too
according to this part of the SubmittingPatches document:
"- send the patch to the list (git@vger.kernel.org) and the maintainer
(gitster@pobox.com) if (and only if) the patch is ready for inclusion."
Thanks,
Christian.
next prev parent reply other threads:[~2010-05-28 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 6:25 [PATCH GSoC 1/4] gitweb: Move static files into seperate subdirectory Pavan Kumar Sunkara
2010-05-28 6:25 ` [PATCH GSoC 2/4] gitweb: Set default destination directory for installing gitweb in Makefile Pavan Kumar Sunkara
2010-05-28 6:25 ` [PATCH GSoC 3/4] git-instaweb: Put httpd logs in a "$httpd_only" subdirectory Pavan Kumar Sunkara
2010-05-28 6:25 ` [PATCH GSoC 4/4] git-instaweb: Configure it to work with new gitweb structure Pavan Kumar Sunkara
2010-05-28 16:56 ` Christian Couder [this message]
2010-05-29 1:10 ` [PATCH GSoC 1/4] gitweb: Move static files into seperate subdirectory Junio C Hamano
2010-05-31 21:36 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005281856.27438.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=pasky@ucw.cz \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).