From: Eric Wong <normalperson@yhbt.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org,
Pavan Kumar Sunkara <pavan.sss1991@gmail.com>,
Petr Baudis <pasky@suse.cz>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCHv4 3/3] git-instaweb: Add support for running gitweb via 'plackup'
Date: Sat, 29 May 2010 02:32:52 +0000 [thread overview]
Message-ID: <20100529023252.GA19705@dcvr.yhbt.net> (raw)
In-Reply-To: <1275073885-26537-4-git-send-email-jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> wrote:
> + open my \$access_log_fh, '>', "\$logdir/access.log"
> + or die "Couldn't open access log '\$logdir/access.log': \$!";
> + open my \$error_log_fh, '>', "\$logdir/error.log"
> + or die "Couldn't open error log '\$logdir/error.log': \$!";
I believe '>>' (append) is preferable for log files and matches the
behavior of all other servers. Other than that everything else looks
good. I can make that change myself + Ack + push for Junio.
--
Eric Wong
next prev parent reply other threads:[~2010-05-29 2:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 19:11 [PATCH 0/3] git-instaweb: Support for 'plackup' and improvements Jakub Narebski
2010-05-28 19:11 ` [PATCH 1/3] git-instaweb: Remove pidfile after stopping web server Jakub Narebski
2010-05-28 19:11 ` [PATCH 2/3] git-instaweb: Wait for server to start before running web browser Jakub Narebski
2010-05-28 19:31 ` Pavan Kumar Sunkara
2010-05-28 19:58 ` Jakub Narebski
2010-05-28 19:11 ` [PATCHv4 3/3] git-instaweb: Add support for running gitweb via 'plackup' Jakub Narebski
2010-05-29 2:32 ` Eric Wong [this message]
2010-05-29 7:21 ` Eric Wong
2010-05-31 21:15 ` [PATCH 0/3] git-instaweb: Support for 'plackup' and improvements Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100529023252.GA19705@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).