From: Johannes Sixt <j6t@kdbg.org>
To: Johan Herland <johan@herland.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] diff.c: Ensure "index $from..$to" line contains unambiguous SHA1s
Date: Sun, 30 May 2010 21:58:40 +0200 [thread overview]
Message-ID: <201005302158.40314.j6t@kdbg.org> (raw)
In-Reply-To: <201005301537.18039.johan@herland.net>
On Sonntag, 30. Mai 2010, Johan Herland wrote:
> +cat >expect_initial <<EOF
> +100644 blob 51d2738463ea4ca66f8691c91e33ce64b7d41bb1 foo
> +EOF
> +
> +cat >expect_update <<EOF
> +100644 blob 51d2738efb4ad8a1e40bed839ab8e116f0a15e47 foo
> +EOF
> +
> +test_expect_success 'setup' '
> + echo 4827 > foo &&
...
> + echo 11742 > foo &&
How the fscking hell did you find these two simple values that are an
almost-SHA1-collision? It's easier to hit the jackpot!?!
-- Hannes
next prev parent reply other threads:[~2010-05-30 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 13:37 [PATCH] diff.c: Ensure "index $from..$to" line contains unambiguous SHA1s Johan Herland
2010-05-30 19:58 ` Johannes Sixt [this message]
2010-05-30 23:23 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005302158.40314.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).