From: Petr Baudis <pasky@suse.cz>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Eric Wong <normalperson@yhbt.net>,
Pavan Kumar Sunkara <pavan.sss1991@gmail.com>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 0/3] git-instaweb: Support for 'plackup' and improvements
Date: Mon, 31 May 2010 23:15:09 +0200 [thread overview]
Message-ID: <20100531211509.GB27342@machine.or.cz> (raw)
In-Reply-To: <1275073885-26537-1-git-send-email-jnareb@gmail.com>
On Fri, May 28, 2010 at 09:11:22PM +0200, Jakub Narebski wrote:
> This series adds support for 'plackup' web server (PSGI/Plack based
> server script) to git-instaweb. Because the web server (by default
> pure-Perl HTTP::Server::PSGI aka PLACK_SERVER=Standalone) can take a
> while to start, it required adding waiting for web server to be ready
> before starting web browser.
>
> This series also contains somewhat unrelated fixup, namely that
> git-instaweb removes pidfile after stopping web server. This is
> probably important only to web servers which do not have daemon mode,
> and are "daemonized" (which includes generating pidfile) by
> git-instaweb itself.
I did not test the series, but looking over it, all appears sane, so
Acked-by: Petr Baudis <pasky@suse.cz>
prev parent reply other threads:[~2010-05-31 21:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 19:11 [PATCH 0/3] git-instaweb: Support for 'plackup' and improvements Jakub Narebski
2010-05-28 19:11 ` [PATCH 1/3] git-instaweb: Remove pidfile after stopping web server Jakub Narebski
2010-05-28 19:11 ` [PATCH 2/3] git-instaweb: Wait for server to start before running web browser Jakub Narebski
2010-05-28 19:31 ` Pavan Kumar Sunkara
2010-05-28 19:58 ` Jakub Narebski
2010-05-28 19:11 ` [PATCHv4 3/3] git-instaweb: Add support for running gitweb via 'plackup' Jakub Narebski
2010-05-29 2:32 ` Eric Wong
2010-05-29 7:21 ` Eric Wong
2010-05-31 21:15 ` Petr Baudis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531211509.GB27342@machine.or.cz \
--to=pasky@suse.cz \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=normalperson@yhbt.net \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).