From: Jonathan Nieder <jrnieder@gmail.com>
To: Greg Price <price@ksplice.com>
Cc: git@vger.kernel.org,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Thomas Rast" <trast@student.ethz.ch>,
"Florian Weimer" <fw@deneb.enyo.de>,
"Jörg Sommer" <joerg@alea.gnuu.de>
Subject: Re: [PATCH] rebase -i -p: document shortcomings
Date: Tue, 1 Jun 2010 03:50:05 -0500 [thread overview]
Message-ID: <20100601085005.GA32320@progeny.tock> (raw)
In-Reply-To: <AANLkTimjcHpbbpfwNoZGq3_1TjfLAzJL3C8Jcp6LeyW0@mail.gmail.com>
Hi Greg,
Greg Price wrote:
> The combination "rebase -i -p" does work correctly in one common use
> case:
[...]
> I suggest s/instruction sheet/todo list/, as the latter terminology
> seems more natural to me
Here’s a rough patch to squash in. Thanks for the ideas.
Sleepily,
Jonathan
diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
index 330e9ea..e27099e 100644
--- a/Documentation/git-rebase.txt
+++ b/Documentation/git-rebase.txt
@@ -309,7 +309,7 @@ link:howto/revert-a-faulty-merge.txt[revert-a-faulty-merge How-To] for details).
+
This uses the `--interactive` machinery internally, but combining it
with the `--interactive` option explicitly is generally not a good
-idea (see BUGS below).
+idea unless you know what you are doing (see BUGS below).
--root::
@@ -614,9 +614,10 @@ case" recovery too!
BUGS
----
-The instruction sheet presented by `--preserve-merges --interactive`
-does not represent the topology of the revision graph. Attempts to
-reorder it tend to produce counterintuitive results.
+The todo list presented by `--preserve-merges --interactive` does not
+represent the topology of the revision graph. Editing commits and
+rewording their commit messages should work fine, but attempts to
+reorder commits tend to produce counterintuitive results.
For example, an attempt to rearrange
------------
--
1.7.1.246.g2fc1b.dirty
next prev parent reply other threads:[~2010-06-01 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 1:43 [PATCH] rebase -i -p: document shortcomings Jonathan Nieder
2010-06-01 2:22 ` Greg Price
2010-06-01 8:50 ` Jonathan Nieder [this message]
2010-06-01 11:40 ` Sverre Rabbelier
2010-06-01 17:24 ` Greg Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601085005.GA32320@progeny.tock \
--to=jrnieder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=fw@deneb.enyo.de \
--cc=git@vger.kernel.org \
--cc=joerg@alea.gnuu.de \
--cc=price@ksplice.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).