From: Jakub Narebski <jnareb@gmail.com>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Cc: git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>,
Petr Baudis <pasky@ucw.cz>
Subject: Re: [PATCH] Makefile: Use $(sharedir)/gitweb for target 'install-gitweb'
Date: Tue, 1 Jun 2010 21:50:02 +0200 [thread overview]
Message-ID: <201006012150.02970.jnareb@gmail.com> (raw)
In-Reply-To: <1275405080-17326-1-git-send-email-pavan.sss1991@gmail.com>
On Tue, 1 June 2010, Pavan Kumar Sunkara wrote:
> Export gitwebdir variable so that when user types the command
> 'make install-gitweb', gitweb is installed in $(sharedir)/gitweb
> rather than /var/www/cgi-bin. Now, $(sharedir)/gitweb is default
> for both 'install' and 'install-gitweb' targets.
>
> Remove 'gitwebdir=$(gitwebdir_SQ)' from gitweb part of 'install'
> target which is unneccessary now.
>
> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
For what it is worth:
Acked-by: Jakub Narebski <jnareb@gmail.com>
(But I have not tested it!)
> ---
> Makefile | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 8f011a5..32e3146 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -294,7 +294,7 @@ lib = lib
> # DESTDIR=
> pathsep = :
>
> -export prefix bindir sharedir sysconfdir
> +export prefix bindir sharedir gitwebdir sysconfdir
Nitpick: why not
+export prefix bindir sharedir sysconfdir gitwebdir
i.e. have 'gitwebdir' last? Not that it matters, though....
>
> CC = gcc
> AR = ar
> @@ -2049,7 +2049,7 @@ install: all
> $(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install
> ifndef NO_PERL
> $(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install
> - $(MAKE) -C gitweb gitwebdir=$(gitwebdir_SQ) install
> + $(MAKE) -C gitweb install
Nice.
> endif
> ifndef NO_PYTHON
> $(MAKE) -C git_remote_helpers prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install
> --
> 1.7.1.447.g40f7.dirty
>
>
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-06-01 19:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 15:11 [PATCH] Makefile: Use $(sharedir)/gitweb for target 'install-gitweb' Pavan Kumar Sunkara
2010-06-01 19:50 ` Jakub Narebski [this message]
2010-06-02 4:31 ` Junio C Hamano
2010-06-02 14:49 ` Pavan Kumar Sunkara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006012150.02970.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=pasky@ucw.cz \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).