From: Christian Couder <chriscool@tuxfamily.org>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Sverre Rabbelier <srabbelier@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH 7/8] Documentation/cherry-pick: describe passing more than one commit
Date: Wed, 2 Jun 2010 07:57:15 +0200 [thread overview]
Message-ID: <201006020757.15117.chriscool@tuxfamily.org> (raw)
In-Reply-To: <AANLkTikHODw5irE-84bkztWhUKgP8v1PG9zTW1Ea6WRs@mail.gmail.com>
On Tuesday 01 June 2010 11:29:32 Ramkumar Ramachandra wrote:
> Hi,
>
> Christian Couder <chriscool@tuxfamily.org> wrote:
> > -n::
> > --no-commit::
> > - Usually the command automatically creates a commit.
> > - This flag applies the change necessary to cherry-pick
> > - the named commit to your working tree and the index,
> > - but does not make the commit. In addition, when this
> > - option is used, your index does not have to match the
> > - HEAD commit. The cherry-pick is done against the
> > - beginning state of your index.
> > + Usually the command automatically creates some commits. This
> > + flag applies the change necessary to cherry-pick the named
> > + commits to your working tree and the index, but does not make
> > + the commits. In addition, when this option is used, your
> > + index does not have to match the HEAD commit. The cherry-pick
> > + is done against the beginning state of your index.
> > +
>
> Avoid re-wrapping the text so it's easy to see the changes that you
> have introduced in subsequent blames- you've just changed the word
> "commit" to "commits".
Ok, avoided the re-wrapping.
> > +Examples
> > +--------
>
> Style nitpick: shouldn't the word "Examples" be in all-caps?
I had a quick look at Documentation/*.txt and found 22 files with "Examples"
and 32 files with "EXAMPLES", so I changed to "EXAMPLES". But if you really
care I suggest you to submit a patch to changes the 22 files that contains
"EXAMPLES".
Thanks,
Christian.
next prev parent reply other threads:[~2010-06-02 5:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 19:42 [PATCH 0/8] implement cherry-picking many commits Christian Couder
2010-05-31 19:42 ` [PATCH 1/8] revert: cleanup code for -x option Christian Couder
2010-05-31 19:42 ` [PATCH 2/8] revert: use run_command_v_opt() instead of execv_git_cmd() Christian Couder
2010-06-01 4:01 ` Jonathan Nieder
2010-06-01 4:33 ` Christian Couder
2010-05-31 19:42 ` [PATCH 3/8] revert: refactor code into a do_pick_commit() function Christian Couder
2010-05-31 19:42 ` [PATCH 4/8] revert: change help_msg() to take no argument Christian Couder
2010-06-01 5:08 ` Jonathan Nieder
2010-06-01 5:40 ` Jeff King
2010-06-01 6:27 ` Jonathan Nieder
2010-05-31 19:42 ` [PATCH 5/8] revert: allow cherry-picking more than one commit Christian Couder
2010-06-01 7:38 ` Sverre Rabbelier
2010-06-01 8:35 ` Jonathan Nieder
2010-06-02 23:37 ` Junio C Hamano
2010-06-03 4:18 ` Christian Couder
2010-06-01 9:03 ` Jonathan Nieder
2010-06-02 5:57 ` Christian Couder
2010-05-31 19:42 ` [PATCH 6/8] revert: add tests to check cherry-picking many commits Christian Couder
2010-05-31 19:42 ` [PATCH 7/8] Documentation/cherry-pick: describe passing more than one commit Christian Couder
2010-06-01 9:29 ` Ramkumar Ramachandra
2010-06-02 5:57 ` Christian Couder [this message]
2010-06-01 9:51 ` Jonathan Nieder
2010-06-01 10:26 ` Ramkumar Ramachandra
2010-06-02 5:57 ` Christian Couder
2010-06-02 5:57 ` Christian Couder
2010-06-02 6:14 ` Jonathan Nieder
2010-06-14 3:33 ` Christian Couder
2010-05-31 19:42 ` [PATCH 8/8] Documentation/revert: " Christian Couder
2010-06-01 13:28 ` Antriksh Pany
2010-06-02 5:57 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006020757.15117.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).