From: Petr Baudis <pasky@suse.cz>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Cc: git@vger.kernel.org, jnareb@gmail.com, chriscool@tuxfamily.org
Subject: Re: [PATCH/RFC] gitweb: Create Gitweb::Git module
Date: Mon, 7 Jun 2010 16:48:52 +0200 [thread overview]
Message-ID: <20100607144852.GN20775@machine.or.cz> (raw)
In-Reply-To: <1275859451-21787-1-git-send-email-pavan.sss1991@gmail.com>
On Mon, Jun 07, 2010 at 02:54:11AM +0530, Pavan Kumar Sunkara wrote:
> @@ -39,9 +38,8 @@ BEGIN {
> # with their descriptions is listed in Gitweb::Config.
> $version = "++GIT_VERSION++";
>
> -# core git executable to use
> -# this can just be "git" if your webserver has a sensible PATH
> -our $GIT = "++GIT_BINDIR++/git";
> +#only this variable has it's root in Gitweb::Git
> +$GIT = "++GIT_BINDIR++/git";
>
> $projectroot = "++GITWEB_PROJECTROOT++";
> $project_maxdepth = "++GITWEB_PROJECT_MAXDEPTH++";
That comment is super-cryptic, I'd suggest either rewording it or
dropping it completely.
> @@ -1548,21 +1536,6 @@ sub get_feed_info {
> ## ----------------------------------------------------------------------
> ## git utility subroutines, invoking git commands
Is there any reason why didn't you move the rest of the commands from
this section to Gitweb::Git as well?
Petr "Pasky" Baudis
next prev parent reply other threads:[~2010-06-07 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-06 21:24 [PATCH/RFC] gitweb: Create Gitweb::Git module Pavan Kumar Sunkara
2010-06-07 8:42 ` Jakub Narebski
2010-06-07 15:31 ` Pavan Kumar Sunkara
2010-06-07 14:48 ` Petr Baudis [this message]
2010-06-07 15:25 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100607144852.GN20775@machine.or.cz \
--to=pasky@suse.cz \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).