From: Jeff King <peff@peff.net>
To: Tor Arntsen <tor@spacetec.no>
Cc: Andreas Ericsson <ae@op5.se>,
Dario Rodriguez <soft.d4rio@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>,
Ben Walton <bwalton@artsci.utoronto.ca>,
git <git@vger.kernel.org>
Subject: Re: [PATCH/RFC] Fix for default pager
Date: Thu, 10 Jun 2010 04:29:16 -0400 [thread overview]
Message-ID: <20100610082916.GA5559@coredump.intra.peff.net> (raw)
In-Reply-To: <AANLkTinAO5empFix9W_rbtU3Vv4O73OsJBtA1stb66DS@mail.gmail.com>
On Wed, Jun 09, 2010 at 11:08:49AM +0200, Tor Arntsen wrote:
> If it's true that Git should demand 'less' to be installed before
> being usable out of the box.. well, that's just plain silly.
It depends on how you define "out of the box". The person compiling it
just needs to set DEFAULT_PAGER appropriately for their system. "less"
is a sane choice for most modern systems. But we can make it even easier
on AIX people with:
diff --git a/Makefile b/Makefile
index 34b7dd5..6ad0aca 100644
--- a/Makefile
+++ b/Makefile
@@ -930,6 +930,7 @@ ifeq ($(uname_S),NetBSD)
HAVE_PATHS_H = YesPlease
endif
ifeq ($(uname_S),AIX)
+ DEFAULT_PAGER = more
NO_STRCASESTR=YesPlease
NO_MEMMEM = YesPlease
NO_MKDTEMP = YesPlease
That won't do automagic run-time detection if you have "less" installed,
but given your claim that AIX's "more" actually doesn't suck, it's
probably a good default. People who care can set their PAGER environment
variable.
-Peff
next prev parent reply other threads:[~2010-06-10 8:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Installing on AIX fails>
2010-06-07 23:58 ` [PATCH/RFC] Fix for default pager Dario Rodriguez
2010-06-08 0:04 ` Ben Walton
2010-06-08 2:14 ` Dario Rodriguez
2010-06-08 5:35 ` Jeff King
2010-06-08 13:49 ` Dario Rodriguez
2010-06-08 14:17 ` Johannes Sixt
2010-06-08 14:39 ` Dario Rodriguez
2010-06-08 15:56 ` Johannes Sixt
2010-06-08 17:28 ` Dario Rodriguez
2010-06-08 18:59 ` Johannes Sixt
2010-06-08 20:44 ` Dario Rodriguez
2010-06-08 21:33 ` Andreas Ericsson
2010-06-09 9:08 ` Tor Arntsen
2010-06-09 9:29 ` Miles Bader
2010-06-10 8:29 ` Jeff King [this message]
2010-06-10 8:48 ` Tor Arntsen
2010-06-10 8:59 ` Jeff King
2010-06-10 9:24 ` Tor Arntsen
2010-06-10 11:31 ` Dario Rodriguez
2010-06-10 14:55 ` Junio C Hamano
2010-06-15 16:11 ` Brandon Casey
2010-06-15 16:32 ` Tor Arntsen
2010-06-16 1:34 ` Nazri Ramliy
2010-06-16 6:28 ` Jeff King
2010-06-09 18:57 ` Ævar Arnfjörð Bjarmason
2010-06-08 5:29 ` Jeff King
2010-06-08 6:12 ` Johannes Sixt
2010-06-08 12:24 ` Dario Rodriguez
2010-06-08 14:04 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610082916.GA5559@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=ae@op5.se \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=soft.d4rio@gmail.com \
--cc=tor@spacetec.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).