From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH/RFC] Fix for default pager Date: Thu, 10 Jun 2010 04:29:16 -0400 Message-ID: <20100610082916.GA5559@coredump.intra.peff.net> References: <20100608053507.GB15156@coredump.intra.peff.net> <4C0E5103.7030501@viscovery.net> <4C0E6810.3070301@viscovery.net> <4C0E932B.3010702@viscovery.net> <4C0EB741.9020905@op5.se> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Andreas Ericsson , Dario Rodriguez , Johannes Sixt , Ben Walton , git To: Tor Arntsen X-From: git-owner@vger.kernel.org Thu Jun 10 10:29:33 2010 connect(): No such file or directory Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OMd8i-000747-Vg for gcvg-git-2@lo.gmane.org; Thu, 10 Jun 2010 10:29:29 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755572Ab0FJI3X (ORCPT ); Thu, 10 Jun 2010 04:29:23 -0400 Received: from peff.net ([208.65.91.99]:51787 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417Ab0FJI3W (ORCPT ); Thu, 10 Jun 2010 04:29:22 -0400 Received: (qmail 2026 invoked by uid 107); 10 Jun 2010 08:29:31 -0000 Received: from coredump.intra.peff.net (HELO coredump.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.40) with (AES128-SHA encrypted) SMTP; Thu, 10 Jun 2010 04:29:31 -0400 Received: by coredump.intra.peff.net (sSMTP sendmail emulation); Thu, 10 Jun 2010 04:29:16 -0400 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, Jun 09, 2010 at 11:08:49AM +0200, Tor Arntsen wrote: > If it's true that Git should demand 'less' to be installed before > being usable out of the box.. well, that's just plain silly. It depends on how you define "out of the box". The person compiling it just needs to set DEFAULT_PAGER appropriately for their system. "less" is a sane choice for most modern systems. But we can make it even easier on AIX people with: diff --git a/Makefile b/Makefile index 34b7dd5..6ad0aca 100644 --- a/Makefile +++ b/Makefile @@ -930,6 +930,7 @@ ifeq ($(uname_S),NetBSD) HAVE_PATHS_H = YesPlease endif ifeq ($(uname_S),AIX) + DEFAULT_PAGER = more NO_STRCASESTR=YesPlease NO_MEMMEM = YesPlease NO_MKDTEMP = YesPlease That won't do automagic run-time detection if you have "less" installed, but given your claim that AIX's "more" actually doesn't suck, it's probably a good default. People who care can set their PAGER environment variable. -Peff