From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>, <git@vger.kernel.org>
Subject: Re: [PATCH next] test-lib: set $DIFF to diff if it is unset
Date: Fri, 11 Jun 2010 18:34:35 +0200 [thread overview]
Message-ID: <201006111834.36226.trast@student.ethz.ch> (raw)
In-Reply-To: <7vhbl9k0jv.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil> writes:
>
> > I think what should be done instead, is to move this section
> > down below the line where GIT-BUILD-OPTIONS is sourced. That
> > way, the value of $DIFF can be gotten from that file.
> >
> > I guess GIT_TEST_CMP and GIT_TEST_CMP_USE_COPIED_CONTEXT
> > should be written into GIT-BUILD-OPTIONS too.
>
> I like that. Something like this?
Fine by me, and tested.
Acked-by: Thomas Rast <trast@student.ethz.ch>
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2010-06-11 16:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 9:39 [PATCH next] test-lib: set $DIFF to diff if it is unset Thomas Rast
2010-06-10 9:46 ` Ævar Arnfjörð Bjarmason
2010-06-10 17:23 ` Brandon Casey
2010-06-11 16:15 ` Junio C Hamano
2010-06-11 16:26 ` Brandon Casey
2010-06-15 15:19 ` Brandon Casey
2010-06-11 16:34 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006111834.36226.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=brandon.casey.ctr@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).