git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>]
Date: Sat, 12 Jun 2010 09:50:21 -0500	[thread overview]
Message-ID: <20100612145021.GA1406@burratino> (raw)
In-Reply-To: <4C1371CE.8010309@gnu.org>

Paolo Bonzini wrote:

> Just a nit, why not just "--open-files-in"?

I assume it was to convey the default.  The effect of
"git grep -e foo --open-files-in-pager" is more obvious than
"git grep -e foo --open-files-in".

But I do see your point.  I have no preferences about what the long
option is named.  Care to prepare a follow-up patch?

> I'm asking because I would like to add this option to GNU
> grep

That would be nice indeed.

Thanks,
Jonathan

      reply	other threads:[~2010-06-12 14:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-05  0:51 [PATCH v2 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>] Jonathan Nieder
2010-06-05  0:53 ` [PATCH 1/2] grep: Add the option '--open-files-in-pager' Jonathan Nieder
2010-06-05  1:40   ` Jonathan Nieder
2010-06-05  0:55 ` [PATCH 2/2] grep -O: allow optional argument specifying the pager (or editor) Jonathan Nieder
2010-06-05 16:11 ` [PATCH v2 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>] Johannes Schindelin
2010-06-12  7:55   ` Jonathan Nieder
2010-06-12  9:46     ` Johannes Schindelin
2010-06-12 16:29       ` [PATCH v3 0/4] " Jonathan Nieder
2010-06-12 16:31         ` [PATCH 1/4] grep: refactor grep_objects loop into its own function Jonathan Nieder
2010-06-12 16:32         ` [PATCH 2/4] Unify code paths of threaded greps Jonathan Nieder
2010-06-12 16:36         ` [PATCH 3/4] grep: Add the option '--open-files-in-pager' Jonathan Nieder
2010-06-12 16:39         ` [PATCH 4/4] grep -O: allow optional argument specifying the pager (or editor) Jonathan Nieder
2010-06-12 17:16           ` Paolo Bonzini
2010-06-13 16:35           ` Junio C Hamano
2010-06-13 17:04             ` Paolo Bonzini
2010-06-14  6:31             ` Jonathan Nieder
2010-06-12 21:36         ` [PATCH v3 0/4] Teach 'git grep' about --open-files-in-pager=[<pager>] Johannes Schindelin
2010-06-12 22:12           ` Jonathan Nieder
2010-06-12 11:38 ` [PATCH v2 0/2] " Paolo Bonzini
2010-06-12 14:50   ` Jonathan Nieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100612145021.GA1406@burratino \
    --to=jrnieder@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=bonzini@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).