* [PATCH] gitweb: Fix typo in hash key name in %opts in git_header_html
@ 2010-06-12 22:35 Jakub Narebski
0 siblings, 0 replies; only message in thread
From: Jakub Narebski @ 2010-06-12 22:35 UTC (permalink / raw)
To: git; +Cc: Jakub Narebski
The name of the key has to be the same in call site handle_errors_html
and in called subroutine that uses it, i.e. git_header_html.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
I'm sorry about that. Stupid mistake.
I have noticed this when working (again) on gitweb output caching
series. There was toss-up on which version ''-no_http_headers'
or '-no_http_header' to choose.
gitweb/gitweb.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 934aacb..e108bbc 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3220,7 +3220,7 @@ sub git_header_html {
}
print $cgi->header(-type=>$content_type, -charset => 'utf-8',
-status=> $status, -expires => $expires)
- unless ($opts{'-no_http_headers'});
+ unless ($opts{'-no_http_header'});
my $mod_perl_version = $ENV{'MOD_PERL'} ? " $ENV{'MOD_PERL'}" : '';
print <<EOF;
<?xml version="1.0" encoding="utf-8"?>
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-06-12 22:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-12 22:35 [PATCH] gitweb: Fix typo in hash key name in %opts in git_header_html Jakub Narebski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).