From: Jeff King <peff@peff.net>
To: "Philippe Bruhat (BooK)" <book@cpan.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Git.pm: better error message
Date: Mon, 14 Jun 2010 05:20:25 -0400 [thread overview]
Message-ID: <20100614092024.GA7854@sigill.intra.peff.net> (raw)
In-Reply-To: <20100614091916.GB31387@swoosh>
On Mon, Jun 14, 2010 at 11:19:16AM +0200, Philippe Bruhat (BooK) wrote:
> Come to think of it, it probably makes sense: -d probably depends on stat
> to get the information about the file, and that fails harder when the
> file in question doesn't exists.
Yeah, that makes sense to me.
> I guess the best would be to put the directory name in the error message
> (always interesting information), and keep $! in case it was set by an
> harder error.
Agreed.
-Peff
next prev parent reply other threads:[~2010-06-14 9:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 1:00 [PATCH] Git.pm: better error message Philippe Bruhat (BooK)
2010-06-14 7:10 ` Jeff King
2010-06-14 9:19 ` Philippe Bruhat (BooK)
2010-06-14 9:20 ` Jeff King [this message]
2010-06-17 23:47 ` Philippe Bruhat (BooK)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614092024.GA7854@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=book@cpan.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).