git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Cc: git@vger.kernel.org, chriscool@tuxfamily.org, pasky@ucw.cz
Subject: Re: [PATCH GSoC] gitweb: Add support for enabling 'write' feature
Date: Tue, 22 Jun 2010 13:12:57 +0200	[thread overview]
Message-ID: <201006221312.57801.jnareb@gmail.com> (raw)
In-Reply-To: <1277159424-6351-1-git-send-email-pavan.sss1991@gmail.com>

On Tue, 22 June 2010, Pavan Kumar Sunkara wrote:

> Provide $feature{'write'} to enable the 'write'
> functionalities for gitweb. While outputting HTML
> it checks for gitweb_check_feature('write') and if
> it's enabled, proper links will appear along with
> the HTML divs.
> 
> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
> ---
>  This patch is based on my previous patch series.
>  http://mid.gmane.org/1277157648-6029-1-git-send-email-pavan.sss1991@gmail.com

It looks a bit like this email is send by accident...
  
>  And this is my first patch in the preparation for integration
>  of write functionality into gitweb.
> 
>  gitweb/lib/Gitweb/Config.pm |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/gitweb/lib/Gitweb/Config.pm b/gitweb/lib/Gitweb/Config.pm
> index c528595..87f0ba6 100644
> --- a/gitweb/lib/Gitweb/Config.pm
> +++ b/gitweb/lib/Gitweb/Config.pm
> @@ -203,6 +203,17 @@ our %feature = (
>  	# (an array) or gitweb_check_feature(<feature>) to check if <feature>
>  	# is enabled
>  
> +	# Enable the 'write' functionalities for gitweb. While outputting HTML
> +	# it checks for gitweb_check_feature('write') and if it's enabled,
> +	# proper links will appear along with the HTML divs.
> +	
> +	# To enable system wide have in $GITWEB_CONFIG
> +	# $feature{'write'}{'default'} = [1];
> +	# Project specific override is not supported.
> +	'write' => {
> +		'override' => 0,
> +		'default' => [0]},
> +
>  	# Enable the 'blame' blob view, showing the last commit that modified
>  	# each line in the file. This can be very CPU-intensive.

...as there is nothing non-trivial in there.

-- 
Jakub Narebski
Poland

  reply	other threads:[~2010-06-22 11:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-21 22:00 [PATCH 00/11 GSoC] gitweb: Split gitweb into modules Pavan Kumar Sunkara
2010-06-21 22:00 ` [PATCH 01/11 GSoC] gitweb: fix esc_url Pavan Kumar Sunkara
2010-06-21 22:00 ` [PATCH 02/11 GSoC] gitweb: Prepare for splitting gitweb Pavan Kumar Sunkara
2010-06-21 22:00 ` [PATCH 03/11 GSoC] gitweb: Create Gitweb::Git module Pavan Kumar Sunkara
2010-06-21 22:00 ` [PATCH 04/11 GSoC] gitweb: Create Gitweb::Config module Pavan Kumar Sunkara
2010-06-21 22:00 ` [PATCH 05/11 GSoC] gitweb: Create Gitweb::Request module Pavan Kumar Sunkara
2010-06-21 22:00 ` [PATCH 06/11 GSoC] gitweb: Create Gitweb::Escape module Pavan Kumar Sunkara
2010-06-21 22:00 ` [PATCH 07/11 GSoC] gitweb: Create Gitweb::RepoConfig module Pavan Kumar Sunkara
2010-06-21 22:00 ` [PATCH 08/11 GSoC] gitweb: Create Gitweb::View module Pavan Kumar Sunkara
2010-06-21 22:00 ` [PATCH 09/11 GSoC] gitweb: Create Gitweb::Util module Pavan Kumar Sunkara
2010-06-21 22:00 ` [PATCH 10/11 GSoC] gitweb: Create Gitweb::Format module Pavan Kumar Sunkara
2010-06-21 22:00 ` [PATCH 11/11 GSoC] gitweb: Create Gitweb::Parse module Pavan Kumar Sunkara
2010-06-21 22:30 ` [PATCH GSoC] gitweb: Add support for enabling 'write' feature Pavan Kumar Sunkara
2010-06-22 11:12   ` Jakub Narebski [this message]
2010-06-22 18:35     ` Pavan Kumar Sunkara
2010-06-22 19:23       ` Jakub Narebski
2010-06-22 11:11 ` [PATCH 00/11 GSoC] gitweb: Split gitweb into modules Jakub Narebski
2010-06-22 18:34   ` Pavan Kumar Sunkara
2010-06-22 20:29     ` Jakub Narebski
2010-06-22 21:04       ` Pavan Kumar Sunkara
2010-06-23  7:59         ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006221312.57801.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=pasky@ucw.cz \
    --cc=pavan.sss1991@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).