From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH v4] Do not decode url protocol. Date: Wed, 23 Jun 2010 13:38:59 -0400 Message-ID: <20100623173859.GA16938@coredump.intra.peff.net> References: <4C211A39.2080207@obry.net> <7v4ogtfylw.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: pascal@obry.net, git list , Matthieu Moy To: Junio C Hamano X-From: git-owner@vger.kernel.org Wed Jun 23 19:39:11 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ORTuo-0008Jc-MO for gcvg-git-2@lo.gmane.org; Wed, 23 Jun 2010 19:39:11 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752399Ab0FWRjE (ORCPT ); Wed, 23 Jun 2010 13:39:04 -0400 Received: from peff.net ([208.65.91.99]:56203 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366Ab0FWRjD (ORCPT ); Wed, 23 Jun 2010 13:39:03 -0400 Received: (qmail 28603 invoked by uid 107); 23 Jun 2010 17:39:52 -0000 Received: from coredump.intra.peff.net (HELO coredump.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.40) with (AES128-SHA encrypted) SMTP; Wed, 23 Jun 2010 13:39:52 -0400 Received: by coredump.intra.peff.net (sSMTP sendmail emulation); Wed, 23 Jun 2010 13:38:59 -0400 Content-Disposition: inline In-Reply-To: <7v4ogtfylw.fsf@alter.siamese.dyndns.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, Jun 23, 2010 at 10:27:39AM -0700, Junio C Hamano wrote: > > When using the protocol git+ssh:// for example we do not want to > > decode the '+' as a space. The url decoding must take place only > > for the server name and parameters. > > > > This fixes a regression introduced in 9d2e942. > > Sign-off? > > As the patch was whitespace-broken, I'm proposing to rewrite it like the > following. > > -- >8 -- > url.c: "://" part at the beginning should not be URL decoded I think this is cleaner than Pascal's patch. Acked-by: Jeff King Thanks all for fixing my bug. :) -Peff