git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 4/4] Makefile: Don't pass $(ALL_CFLAGS) to the linker
Date: Wed, 23 Jun 2010 16:08:20 -0500	[thread overview]
Message-ID: <20100623210820.GA24242@burratino> (raw)
In-Reply-To: <4C226520.5080009@ramsay1.demon.co.uk>

Hi Ramsay,

Ramsay Jones wrote:

>     LINK : warning LNK4044: unrecognized option '/Zi'; ignored
> 
> In order to suppress the warning, we refrain from passing the
> $(ALL_CFLAGS) macro to the linker.
> 
> Note that, should it be necessary in the future, an option
> intended for both the (front-end) compiler and the linker can
> be included in both CFLAGS and LDFLAGS.

I think traditionally CPPFLAGS is meant to be used for the purpose
you are describing (see [1] for example).

I realize that the Makefile does not currently use the terms this way:
making it consistent would require

 . s/BASIC_CFLAGS/BASIC_CPPFLAGS/, except that the

	BASIC_CFLAGS += -Kthread

   settings should probably stay as-is

 . Windows BASIC_CFLAGS would probably need to be split:

	BASIC_CFLAGS = -nologo
	BASIC_CPPFLAGS = -I. -I../zlib ... -DWIN32 ...

 . s/COMPAT_CFLAGS/COMPAT_CPPFLAGS

What do you think?
Jonathan

[1] http://www.gnu.org/software/autoconf/manual/html_node/Preset-Output-Variables.html#index-CFLAGS-80

  reply	other threads:[~2010-06-23 21:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-23 19:48 [PATCH 4/4] Makefile: Don't pass $(ALL_CFLAGS) to the linker Ramsay Jones
2010-06-23 21:08 ` Jonathan Nieder [this message]
2010-06-26 17:59   ` Ramsay Jones
2010-06-26 18:19     ` Jonathan Nieder
2010-06-30 19:40       ` Ramsay Jones
2010-06-30 21:16         ` Andreas Schwab
2010-06-27  9:44     ` Bernhard R. Link
2010-06-24 15:30 ` Peter Harris
2010-06-25 20:24   ` Ramsay Jones
2010-06-27 20:45     ` Peter Harris
2010-06-30 19:52       ` Ramsay Jones
2010-07-01 21:27         ` Peter Harris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100623210820.GA24242@burratino \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ramsay@ramsay1.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).