git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Finn Arne Gangstad <finnag@pvv.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eyvind Bernhardsen <eyvind.bernhardsen@gmail.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2010, #04; Wed, 23)
Date: Thu, 24 Jun 2010 13:17:57 +0200	[thread overview]
Message-ID: <20100624111757.GB3453@pvv.org> (raw)
In-Reply-To: <7viq59e6zn.fsf@alter.siamese.dyndns.org>

On Wed, Jun 23, 2010 at 03:09:32PM -0700, Junio C Hamano wrote:

> * eb/double-convert-before-merge (2010-06-16) 1 commit
>  - ll-merge: Normalize files before merging
> 
> If running git-to-worktree and then worktree-to-git _fixes_ something, it
> means that these are not roundtrip operations; there is something that is
> fundamentally wrong.  The commit log message doesn't help explaining it,
> either.

If .gitattributes is different on the different sides, or if you
enable autocrlf, the current repo contents may change after
git-to-worktree and worktree-to-git again. This is most easily seen if
you add some eol attributes, but also with clean/smudge filters, ident
and so on.

Assume you start out with a repo that has a lot of text files with
CRLF checked in (A).

  C----
 /     \
A---B---D

B: Add "* text=auto" to .gitattributes and normalize all files to LF
only in repo

D: try to merge C

Without this patch you will get a ridiculous number of lf/crlf
conflicts when trying to merge C into D, since the repository contents
for C are "wrong" wrt the new .gitattributes file.

- Finn Arne

  parent reply	other threads:[~2010-06-24 11:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-23 22:09 What's cooking in git.git (Jun 2010, #04; Wed, 23) Junio C Hamano
     [not found] ` <7veifxe63j.fsf@alter.siamese.dyndns.org>
2010-06-23 22:54   ` [PATCH] bash completion: Support "divergence from upstream" messages in __git_ps1 Shawn O. Pearce
2010-06-23 23:21 ` What's cooking in git.git (Jun 2010, #04; Wed, 23) Ævar Arnfjörð Bjarmason
2010-06-24  0:44 ` Nazri Ramliy
2010-06-24  3:46 ` Tay Ray Chuan
2010-06-24 11:17 ` Finn Arne Gangstad [this message]
2010-06-24 11:42   ` Johannes Sixt
2010-06-24 11:58     ` Finn Arne Gangstad
2010-06-24 12:23     ` Eyvind Bernhardsen
2010-06-24 20:21   ` Junio C Hamano
2010-06-24 20:51     ` Eyvind Bernhardsen
2010-06-24 22:48       ` Junio C Hamano
2010-06-25  8:43         ` Finn Arne Gangstad
2010-06-25 19:43         ` Eyvind Bernhardsen
2010-06-25 21:17           ` Junio C Hamano
2010-06-25  6:02     ` Johannes Sixt
2010-06-25  7:46     ` Finn Arne Gangstad
2010-06-24 14:48 ` Johannes Sixt
2010-06-24 15:33   ` git log --objects Holger Hellmuth
2010-06-25 10:06     ` Santi Béjar
2010-06-24 15:41   ` What's cooking in git.git (Jun 2010, #04; Wed, 23) Clément Poulain
2010-06-25  2:27 ` Christian Couder
2010-06-25 10:30 ` Ævar Arnfjörð Bjarmason
2010-06-25 13:43 ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100624111757.GB3453@pvv.org \
    --to=finnag@pvv.org \
    --cc=eyvind.bernhardsen@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).