From: Johannes Sixt <j6t@kdbg.org>
To: Brian Gernhardt <brian@gernhardtsoftware.com>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t4027, t4041: Use printf instead of echo -n
Date: Thu, 24 Jun 2010 21:34:53 +0200 [thread overview]
Message-ID: <201006242134.54081.j6t@kdbg.org> (raw)
In-Reply-To: <1277401578-20984-1-git-send-email-brian@gernhardtsoftware.com>
On Donnerstag, 24. Juni 2010, Brian Gernhardt wrote:
> BSD's echo doesn't recognize the -n option, so use printf instead
...
> - echo -n "" | test_cmp - actual2 &&
> + printf "" | test_cmp - actual2 &&
Shouldn't you replace these by
! test -s actual2 &&
-- Hannes
next prev parent reply other threads:[~2010-06-24 19:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 17:46 [PATCH] t4027, t4041: Use printf instead of echo -n Brian Gernhardt
2010-06-24 19:34 ` Johannes Sixt [this message]
2010-06-24 20:10 ` [PATCH v2] t4027,4041: Use test -s to test for an empty file Brian Gernhardt
2010-06-24 20:55 ` Junio C Hamano
2010-06-25 16:26 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006242134.54081.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).