From: Jonathan Nieder <jrnieder@gmail.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Tay Ray Chuan <rctay89@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
Johan Herland <johan@herland.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Andy Parkins <andyparkins@gmail.com>
Subject: Re: git-gui and gitk-git as submodules
Date: Sat, 26 Jun 2010 13:31:54 -0500 [thread overview]
Message-ID: <20100626183154.GA13581@burratino> (raw)
In-Reply-To: <4C25E83E.4080905@web.de>
Jens Lehmann wrote:
> 1) Switching branches, merging, rebasing and resetting in the
> superproject must result in a checkout of the matching submodule
> work tree
Switching branches can change the HEAD commit of an already checked
out submodule, and switching branches can change the list of
submodules.
For the latter, maybe it would make sense to introduce ‘git checkout
--recursive’ which runs ‘submodule update --init --recursive’ after
checkout. IMHO, in git 2.0 this even ought to be made the default.
One could use --no-recursive to access the more flexible traditional
behavior.
> 2) On "git clone" the submodules must be cloned and checked out too
Does ‘git clone --recursive’ take care of it?
The Makefile would need to be tweaked to give a reasonable message
when the caller forgets to check out an important submodule.
> 3) Switching between commits in the superproject where a directory
> is replaced by a submodule or vice versa doesn't work right now.
> Submodules should handle this situation, otherwise the commit
> putting gitk and git gui into submodules would become a barrier.
Yes, this is the fatal problem imho since it would affect basic
maintainance tasks. I consider maintainance of the branch (rather
than consumption) the most important piece to begin with; for a branch
not in next, usability problems can be resolved over time.
> I am working on these issues, but that will take some time. But when
> they are solved, me too thinks that these two should become submodules.
Thanks for the explanation.
next prev parent reply other threads:[~2010-06-26 18:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 14:55 [RFC PATCH 0/2] Teach "git status" the "--ignore-submodules" option Jens Lehmann
2010-06-25 14:56 ` [PATCH 1/2] git submodule: ignore dirty submodules for summary and status Jens Lehmann
2010-06-25 14:56 ` [PATCH 2/2] Add the option "--ignore-submodules" to "git status" Jens Lehmann
2010-06-25 18:24 ` [RFC PATCH 0/2] Teach "git status" the "--ignore-submodules" option Junio C Hamano
2010-06-25 19:01 ` git-gui and gitk-git as submodules (Re: [RFC PATCH 0/2] Teach "git status" the "--ignore-submodules" option) Jonathan Nieder
2010-06-26 4:44 ` Tay Ray Chuan
2010-06-26 11:45 ` Jens Lehmann
2010-06-26 18:31 ` Jonathan Nieder [this message]
2010-06-28 18:58 ` git-gui and gitk-git as submodules Jens Lehmann
2010-06-28 18:29 ` git-gui and gitk-git as submodules (Re: [RFC PATCH 0/2] Teach "git status" the "--ignore-submodules" option) Marc Branchaud
2010-06-28 19:00 ` Jens Lehmann
2010-06-28 19:55 ` Marc Branchaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100626183154.GA13581@burratino \
--to=jrnieder@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).