git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: newren@gmail.com
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Update t3508 status
Date: Tue, 29 Jun 2010 19:04:33 +0200	[thread overview]
Message-ID: <201006291904.34009.chriscool@tuxfamily.org> (raw)
In-Reply-To: <1277775091-13313-1-git-send-email-newren@gmail.com>

On Tuesday 29 June 2010 03:31:31 newren@gmail.com wrote:
> From: Elijah Newren <newren@gmail.com>
> 
> Test #8 of t3508-cherry-pick-many-commits.sh has been fixed since
> 3af0bba8bff88ec1b078aae966a59af26c7a0718.
> 
> Signed-off-by: Elijah Newren <newren@gmail.com>
> ---
>  t/t3508-cherry-pick-many-commits.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/t/t3508-cherry-pick-many-commits.sh
> b/t/t3508-cherry-pick-many-commits.sh index 93d7189..f90ed3d 100755
> --- a/t/t3508-cherry-pick-many-commits.sh
> +++ b/t/t3508-cherry-pick-many-commits.sh
> @@ -82,7 +82,7 @@ test_expect_success 'revert fourth fourth~1 fourth~2
> works' ' git diff --quiet HEAD first
>  '
> 
> -test_expect_failure 'cherry-pick -3 fourth works' '
> +test_expect_success 'cherry-pick -3 fourth works' '
>  	git checkout -f master &&
>  	git reset --hard first &&
>  	test_tick &&

I tried to put this hunk in the following patch:

http://thread.gmane.org/gmane.comp.version-control.git/149156/

but Junio said in a private mail that the test did not pass for him so he 
dropped this hunk.

By the way it looks like the third patch in the series has been lost:

http://thread.gmane.org/gmane.comp.version-control.git/149157

Thanks,
Christian.

      parent reply	other threads:[~2010-06-29 17:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29  1:31 [PATCH] Update t3508 status newren
2010-06-29 16:40 ` Junio C Hamano
2010-06-29 16:50   ` Jonathan Nieder
2010-06-29 17:22     ` Junio C Hamano
2010-06-29 17:04 ` Christian Couder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006291904.34009.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).