From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/8] t/README: Tests are all +x, ./test, not sh ./test
Date: Thu, 1 Jul 2010 11:42:12 -0400 [thread overview]
Message-ID: <20100701154211.GA15542@sigill.intra.peff.net> (raw)
In-Reply-To: <1277997004-29504-2-git-send-email-avarab@gmail.com>
On Thu, Jul 01, 2010 at 03:09:57PM +0000, Ævar Arnfjörð Bjarmason wrote:
> They all run with a #!/bin/sh shebang, but it's probably better to use
> the ./ form anyway.
If we want to be nitpicky, they are actually run by "make test" with
$SHELL_PATH. We don't re-write the shebang lines in the test scripts (as
we do with the actual git-* scripts), so running "./t-whatever" won't
work if you have a broken shell (e.g., Solaris). You have to do "bash
./t-whatever".
-Peff
next prev parent reply other threads:[~2010-07-01 15:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 15:09 [PATCH 0/8] Improvements for t/README Ævar Arnfjörð Bjarmason
2010-07-01 15:09 ` [PATCH 1/8] t/README: Tests are all +x, ./test, not sh ./test Ævar Arnfjörð Bjarmason
2010-07-01 15:42 ` Jeff King [this message]
2010-07-01 15:09 ` [PATCH 2/8] t/README: The trash is in 't/trash directory.$name' Ævar Arnfjörð Bjarmason
2010-07-01 15:44 ` Jeff King
2010-07-01 15:09 ` [PATCH 3/8] t/README: Typo: paralell -> parallel Ævar Arnfjörð Bjarmason
2010-07-01 15:10 ` [PATCH 4/8] t/README: Document the prereq functions, and 3-arg test_* Ævar Arnfjörð Bjarmason
2010-07-01 16:37 ` Junio C Hamano
2010-07-01 15:10 ` [PATCH 5/8] t/README: Document test_external* Ævar Arnfjörð Bjarmason
2010-07-01 16:38 ` Junio C Hamano
2010-07-01 15:10 ` [PATCH 6/8] t/README: Document test_expect_code Ævar Arnfjörð Bjarmason
2010-07-01 15:10 ` [PATCH 7/8] t/README: Add a section about skipping tests Ævar Arnfjörð Bjarmason
2010-07-01 15:10 ` [PATCH 8/8] t/README: Document the dangers of printing "ok" / "not ok" Ævar Arnfjörð Bjarmason
2010-07-01 17:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701154211.GA15542@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).