From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] t0006: test timezone parsing
Date: Tue, 6 Jul 2010 03:54:33 -0400 [thread overview]
Message-ID: <20100706075433.GD3567@sigill.intra.peff.net> (raw)
In-Reply-To: <20100706072849.GA3567@sigill.intra.peff.net>
On Tue, Jul 06, 2010 at 03:28:49AM -0400, Jeff King wrote:
> > On FreeBSD 8.0, we now see this.
> >
> > cc1: warnings being treated as errors
> > test-date.c: In function 'parse_dates':
> > test-date.c:28: warning: format '%ld' expects type 'long int *', but argument 3 has type 'time_t *'
>
> Meh. I was worried about that when I used sscanf. I think we can just do
> this:
Oh, I see this is already on maint. :) So here is my fixup in a nicer
form:
-- >8 --
Subject: [PATCH] test-date: fix sscanf type conversion
Reading into a time_t isn't portable, since we don't know
the exact type. Instead, use an unsigned long, which is what
show_date wants, anyway.
Signed-off-by: Jeff King <peff@peff.net>
---
test-date.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/test-date.c b/test-date.c
index ac6854a..6bcd5b0 100644
--- a/test-date.c
+++ b/test-date.c
@@ -20,12 +20,12 @@ static void parse_dates(char **argv, struct timeval *now)
{
for (; *argv; argv++) {
char result[100];
- time_t t;
+ unsigned long t;
int tz;
result[0] = 0;
parse_date(*argv, result, sizeof(result));
- if (sscanf(result, "%ld %d", &t, &tz) == 2)
+ if (sscanf(result, "%lu %d", &t, &tz) == 2)
printf("%s -> %s\n",
*argv, show_date(t, tz, DATE_ISO8601));
else
--
1.7.2.rc1.214.g5a9d0
next prev parent reply other threads:[~2010-07-06 7:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-04 10:48 [PATCH 1/2] t0006: test timezone parsing Jeff King
2010-07-04 11:00 ` [PATCH 2/2] parse_date: fix signedness in timezone calculation Jeff King
2010-07-06 2:35 ` Junio C Hamano
2010-07-06 23:34 ` [PATCH] t/t0006: specify timezone as EST5 not EST to comply with POSIX Brandon Casey
2010-07-07 9:48 ` Alex Riesen
2010-07-07 18:12 ` Jeff King
2010-07-07 22:59 ` Andreas Schwab
2010-07-06 7:01 ` [PATCH 1/2] t0006: test timezone parsing Junio C Hamano
2010-07-06 7:28 ` Jeff King
2010-07-06 7:54 ` Jeff King [this message]
2010-07-07 5:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100706075433.GD3567@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).