From: tytso@mit.edu
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: jeffpc@josefsipek.net, Git Mailing List <git@vger.kernel.org>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] guilt: Make sure the commit time is increasing
Date: Tue, 6 Jul 2010 13:12:31 -0400 [thread overview]
Message-ID: <20100706171231.GL25518@thunk.org> (raw)
In-Reply-To: <20100706150917.GA1558@burratino>
On Tue, Jul 06, 2010 at 10:09:17AM -0500, Jonathan Nieder wrote:
>
> I have never heard of any version of Git copying poorly with #1
> (commits with the same timestamp). Avoiding it artificially leads
> inevitably to timestamps in the future when you somehow try to assign
> 100 timestamps for the series you have rebased on top of a patch
> committed a few seconds ago.
>
> Incrementing the timestamp to ensure strictly monotonic commits seems
> like a recipe for trouble to me.
Um, I'm guessing you spent a lot of time typing your note, but not a
lot of time looking at my most recent patch? My most recent patch for
guilt simply will set the time of the patch to the current time to
avoid setting it into the future.
- Ted
next prev parent reply other threads:[~2010-07-06 17:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 2:23 [PATCH] guilt: Make sure the commit time is increasing Theodore Ts'o
2010-07-05 2:51 ` tytso
2010-07-05 3:01 ` jeffpc
2010-07-05 2:59 ` jeffpc
2010-07-05 11:06 ` Theodore Tso
2010-07-05 18:52 ` jeffpc
2010-07-05 19:22 ` tytso
2010-07-06 8:03 ` Jonathan Nieder
2010-07-06 10:56 ` Theodore Tso
2010-07-06 15:09 ` Jonathan Nieder
2010-07-06 17:12 ` tytso [this message]
2010-07-06 17:29 ` Jonathan Nieder
2010-07-06 13:53 ` Erik Faye-Lund
2010-07-06 14:29 ` Jeff King
2010-07-06 15:02 ` Erik Faye-Lund
2010-07-06 17:21 ` tytso
2010-07-06 17:29 ` jeffpc
2010-07-06 18:57 ` tytso
2010-07-14 3:01 ` Josef 'Jeff' Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100706171231.GL25518@thunk.org \
--to=tytso@mit.edu \
--cc=git@vger.kernel.org \
--cc=jeffpc@josefsipek.net \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).